Skip to content

Commit 7f57b29

Browse files
Qinglang Miaobrgl
authored andcommitted
gpio: zynq: fix reference leak in zynq_gpio functions
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in a reference leak here. A new function pm_runtime_resume_and_get is introduced in [0] to keep usage counter balanced. So We fix the reference leak by replacing it with new funtion. [0] dd8088d ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: c2df3de ("gpio: zynq: properly support runtime PM for GPIO used as interrupts") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
1 parent 6dbbf84 commit 7f57b29

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/gpio/gpio-zynq.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -574,7 +574,7 @@ static int zynq_gpio_irq_reqres(struct irq_data *d)
574574
struct gpio_chip *chip = irq_data_get_irq_chip_data(d);
575575
int ret;
576576

577-
ret = pm_runtime_get_sync(chip->parent);
577+
ret = pm_runtime_resume_and_get(chip->parent);
578578
if (ret < 0)
579579
return ret;
580580

@@ -942,7 +942,7 @@ static int zynq_gpio_probe(struct platform_device *pdev)
942942

943943
pm_runtime_set_active(&pdev->dev);
944944
pm_runtime_enable(&pdev->dev);
945-
ret = pm_runtime_get_sync(&pdev->dev);
945+
ret = pm_runtime_resume_and_get(&pdev->dev);
946946
if (ret < 0)
947947
goto err_pm_dis;
948948

0 commit comments

Comments
 (0)