Skip to content

Commit 7cd7120

Browse files
wangxiaoningnxpbroonie
authored andcommitted
spi: imx: fix the unbalanced spi runtime pm management
If set active without increase the usage count of pm, the dont use autosuspend function will call the suspend callback to close the two clocks of spi because the usage count is reduced to -1. This will cause the warning dump below when the defer-probe occurs. [ 129.379701] ecspi2_root_clk already disabled [ 129.384005] WARNING: CPU: 1 PID: 33 at drivers/clk/clk.c:952 clk_core_disable+0xa4/0xb0 So add the get noresume function before set active. Fixes: 43b6bf4 spi: imx: fix runtime pm support for !CONFIG_PM Signed-off-by: Clark Wang <xiaoning.wang@nxp.com> Link: https://lore.kernel.org/r/20201124085247.18025-1-xiaoning.wang@nxp.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 71d8056 commit 7cd7120

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/spi/spi-imx.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1686,6 +1686,7 @@ static int spi_imx_probe(struct platform_device *pdev)
16861686

16871687
pm_runtime_set_autosuspend_delay(spi_imx->dev, MXC_RPM_TIMEOUT);
16881688
pm_runtime_use_autosuspend(spi_imx->dev);
1689+
pm_runtime_get_noresume(spi_imx->dev);
16891690
pm_runtime_set_active(spi_imx->dev);
16901691
pm_runtime_enable(spi_imx->dev);
16911692

0 commit comments

Comments
 (0)