Skip to content

Commit 7c8011d

Browse files
committed
Merge tag 'phy-fixes-5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy into usb-linus
Vinod writes: phy: fixes for 5.10 Bunch of fixes for phy drivers: *) USB phy incorrect clearing of bits *) Tegra xusb dangling pointer *) qcom-qmp null ptr initialization *) cpcap-usb irq flags *) intel kkembay kconfig depends *) qualcomm OF dependency *) mediatek typo * tag 'phy-fixes-5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy: phy: mediatek: fix spelling mistake in Kconfig "veriosn" -> "version" phy: qualcomm: Fix 28 nm Hi-Speed USB PHY OF dependency phy: qualcomm: usb: Fix SuperSpeed PHY OF dependency phy: intel: PHY_INTEL_KEEMBAY_EMMC should depend on ARCH_KEEMBAY phy: cpcap-usb: Use IRQF_ONESHOT phy: qcom-qmp: Initialize another pointer to NULL phy: tegra: xusb: Fix dangling pointer on probe failure phy: usb: Fix incorrect clearing of tca_drv_sel bit in SETUP reg for 7211
2 parents 24880a8 + fb89b25 commit 7c8011d

7 files changed

Lines changed: 8 additions & 11 deletions

File tree

drivers/phy/broadcom/phy-brcm-usb-init-synopsys.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -270,11 +270,6 @@ static void usb_init_common_7211b0(struct brcm_usb_init_params *params)
270270
reg |= params->mode << USB_PHY_UTMI_CTL_1_PHY_MODE_SHIFT;
271271
brcm_usb_writel(reg, usb_phy + USB_PHY_UTMI_CTL_1);
272272

273-
/* Fix the incorrect default */
274-
reg = brcm_usb_readl(ctrl + USB_CTRL_SETUP);
275-
reg &= ~USB_CTRL_SETUP_tca_drv_sel_MASK;
276-
brcm_usb_writel(reg, ctrl + USB_CTRL_SETUP);
277-
278273
usb_init_common(params);
279274

280275
/*

drivers/phy/intel/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
#
55
config PHY_INTEL_KEEMBAY_EMMC
66
tristate "Intel Keem Bay EMMC PHY driver"
7-
depends on (OF && ARM64) || COMPILE_TEST
7+
depends on ARCH_KEEMBAY || COMPILE_TEST
88
depends on HAS_IOMEM
99
select GENERIC_PHY
1010
select REGMAP_MMIO

drivers/phy/mediatek/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ config PHY_MTK_TPHY
1212
it supports multiple usb2.0, usb3.0 ports, PCIe and
1313
SATA, and meanwhile supports two version T-PHY which have
1414
different banks layout, the T-PHY with shared banks between
15-
multi-ports is first version, otherwise is second veriosn,
15+
multi-ports is first version, otherwise is second version,
1616
so you can easily distinguish them by banks layout.
1717

1818
config PHY_MTK_UFS

drivers/phy/motorola/phy-cpcap-usb.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,8 @@ static int cpcap_usb_init_irq(struct platform_device *pdev,
364364

365365
error = devm_request_threaded_irq(ddata->dev, irq, NULL,
366366
cpcap_phy_irq_thread,
367-
IRQF_SHARED,
367+
IRQF_SHARED |
368+
IRQF_ONESHOT,
368369
name, ddata);
369370
if (error) {
370371
dev_err(ddata->dev, "could not get irq %s: %i\n",

drivers/phy/qualcomm/Kconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ config PHY_QCOM_USB_HSIC
8787

8888
config PHY_QCOM_USB_HS_28NM
8989
tristate "Qualcomm 28nm High-Speed PHY"
90-
depends on ARCH_QCOM || COMPILE_TEST
90+
depends on OF && (ARCH_QCOM || COMPILE_TEST)
9191
depends on EXTCON || !EXTCON # if EXTCON=m, this cannot be built-in
9292
select GENERIC_PHY
9393
help
@@ -98,7 +98,7 @@ config PHY_QCOM_USB_HS_28NM
9898

9999
config PHY_QCOM_USB_SS
100100
tristate "Qualcomm USB Super-Speed PHY driver"
101-
depends on ARCH_QCOM || COMPILE_TEST
101+
depends on OF && (ARCH_QCOM || COMPILE_TEST)
102102
depends on EXTCON || !EXTCON # if EXTCON=m, this cannot be built-in
103103
select GENERIC_PHY
104104
help

drivers/phy/qualcomm/phy-qcom-qmp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3926,7 +3926,7 @@ static int qcom_qmp_phy_probe(struct platform_device *pdev)
39263926
struct phy_provider *phy_provider;
39273927
void __iomem *serdes;
39283928
void __iomem *usb_serdes;
3929-
void __iomem *dp_serdes;
3929+
void __iomem *dp_serdes = NULL;
39303930
const struct qmp_phy_combo_cfg *combo_cfg = NULL;
39313931
const struct qmp_phy_cfg *cfg = NULL;
39323932
const struct qmp_phy_cfg *usb_cfg = NULL;

drivers/phy/tegra/xusb.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1242,6 +1242,7 @@ static int tegra_xusb_padctl_probe(struct platform_device *pdev)
12421242
reset:
12431243
reset_control_assert(padctl->rst);
12441244
remove:
1245+
platform_set_drvdata(pdev, NULL);
12451246
soc->ops->remove(padctl);
12461247
return err;
12471248
}

0 commit comments

Comments
 (0)