Skip to content

Commit 73c5265

Browse files
Colin Ian Kingjgunthorpe
authored andcommitted
RDMA/bnxt_re: Fix sizeof mismatch for allocation of pbl_tbl.
An incorrect sizeof is being used, u64 * is not correct, it should be just u64 for a table of umem_pgs number of u64 items in the pbl_tbl. Use the idiom sizeof(*pbl_tbl) to get the object type without the need to explicitly use u64. Link: https://lore.kernel.org/r/20201006114700.537916-1-colin.king@canonical.com Addresses-Coverity: ("Sizeof not portable (SIZEOF_MISMATCH)") Fixes: 1ac5a40 ("RDMA/bnxt_re: Add bnxt_re RoCE driver") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
1 parent 6ef999f commit 73c5265

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/infiniband/hw/bnxt_re/ib_verbs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3846,7 +3846,7 @@ struct ib_mr *bnxt_re_reg_user_mr(struct ib_pd *ib_pd, u64 start, u64 length,
38463846
}
38473847

38483848
umem_pgs = ib_umem_num_dma_blocks(umem, page_size);
3849-
pbl_tbl = kcalloc(umem_pgs, sizeof(u64 *), GFP_KERNEL);
3849+
pbl_tbl = kcalloc(umem_pgs, sizeof(*pbl_tbl), GFP_KERNEL);
38503850
if (!pbl_tbl) {
38513851
rc = -ENOMEM;
38523852
goto free_umem;

0 commit comments

Comments
 (0)