Skip to content

Commit 72789a4

Browse files
liupingfanwilldeacon
authored andcommitted
arm64/relocate_kernel: remove redundant code
Kernel startup entry point requires disabling MMU and D-cache. As for kexec-reboot, taking a close look at "msr sctlr_el1, x12" in __cpu_soft_restart as the following: -1. booted at EL1 The instruction is enough to disable MMU and I/D cache for EL1 regime. -2. booted at EL2, using VHE Access to SCTLR_EL1 is redirected to SCTLR_EL2 in EL2. So the instruction is enough to disable MMU and clear I+C bits for EL2 regime. -3. booted at EL2, not using VHE The instruction itself can not affect EL2 regime. But The hyp-stub doesn't enable the MMU and I/D cache for EL2 regime. And KVM also disable them for EL2 regime when its unloaded, or execute a HVC_SOFT_RESTART call. So when kexec-reboot, the code in KVM has prepare the requirement. As a conclusion, disabling MMU and clearing I+C bits in SYM_CODE_START(arm64_relocate_new_kernel) is redundant, and can be removed Signed-off-by: Pingfan Liu <kernelfans@gmail.com> Cc: James Morse <james.morse@arm.com> Cc: Geoff Levand <geoff@infradead.org> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Marc Zyngier <maz@kernel.org> Cc: Mark Brown <broonie@kernel.org> Cc: Kees Cook <keescook@chromium.org> Cc: Remi Denis-Courmont <remi.denis.courmont@huawei.com> Cc: Ard Biesheuvel <ardb@kernel.org> Cc: kvmarm@lists.cs.columbia.edu Link: https://lore.kernel.org/r/1598621998-20563-1-git-send-email-kernelfans@gmail.com To: linux-arm-kernel@lists.infradead.org Signed-off-by: Will Deacon <will@kernel.org>
1 parent f75aef3 commit 72789a4

2 files changed

Lines changed: 4 additions & 12 deletions

File tree

arch/arm64/kernel/cpu-reset.S

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@ SYM_CODE_START(__cpu_soft_restart)
3535
mov_q x13, SCTLR_ELx_FLAGS
3636
bic x12, x12, x13
3737
pre_disable_mmu_workaround
38+
/*
39+
* either disable EL1&0 translation regime or disable EL2&0 translation
40+
* regime if HCR_EL2.E2H == 1
41+
*/
3842
msr sctlr_el1, x12
3943
isb
4044

arch/arm64/kernel/relocate_kernel.S

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,6 @@ SYM_CODE_START(arm64_relocate_new_kernel)
3636
mov x14, xzr /* x14 = entry ptr */
3737
mov x13, xzr /* x13 = copy dest */
3838

39-
/* Clear the sctlr_el2 flags. */
40-
mrs x0, CurrentEL
41-
cmp x0, #CurrentEL_EL2
42-
b.ne 1f
43-
mrs x0, sctlr_el2
44-
mov_q x1, SCTLR_ELx_FLAGS
45-
bic x0, x0, x1
46-
pre_disable_mmu_workaround
47-
msr sctlr_el2, x0
48-
isb
49-
1:
50-
5139
/* Check if the new image needs relocation. */
5240
tbnz x16, IND_DONE_BIT, .Ldone
5341

0 commit comments

Comments
 (0)