Skip to content

Commit 704c231

Browse files
committed
ext4: drop fast_commit from /proc/mounts
The options in /proc/mounts must be valid mount options --- and fast_commit is not a mount option. Otherwise, command sequences like this will fail: # mount /dev/vdc /vdc # mkdir -p /vdc/phoronix_test_suite /pts # mount --bind /vdc/phoronix_test_suite /pts # mount -o remount,nodioread_nolock /pts mount: /pts: mount point not mounted or bad option. And in the system logs, you'll find: EXT4-fs (vdc): Unrecognized mount option "fast_commit" or missing value Fixes: 995a3ed ("ext4: add fast_commit feature and handling for extended mount options") Signed-off-by: Theodore Ts'o <tytso@mit.edu>
1 parent 09162bc commit 704c231

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

fs/ext4/super.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2638,10 +2638,6 @@ static int _ext4_show_options(struct seq_file *seq, struct super_block *sb,
26382638
} else if (test_opt2(sb, DAX_INODE)) {
26392639
SEQ_OPTS_PUTS("dax=inode");
26402640
}
2641-
2642-
if (test_opt2(sb, JOURNAL_FAST_COMMIT))
2643-
SEQ_OPTS_PUTS("fast_commit");
2644-
26452641
ext4_show_quota_options(seq, sb);
26462642
return 0;
26472643
}

0 commit comments

Comments
 (0)