Skip to content

Commit 6699e91

Browse files
ionela-voinescurafaeljw
authored andcommitted
arm: disable frequency invariance for CONFIG_BL_SWITCHER
big.LITTLE switching complicates the setting of a correct cpufreq-based frequency invariance scale factor due to (as observed in drivers/cpufreq/vexpress-spc-cpufreq.c): - Incorrect current and maximum frequencies as a result of the exposure of a virtual frequency table to the cpufreq core, - Missed updates as a result of asynchronous frequency adjustments caused by frequency changes in other CPU pairs. Given that its functionality is atypical in regards to frequency invariance and this is an old technology, disable frequency invariance for when big.LITTLE switching is configured in to prevent incorrect scale setting. Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com> Suggested-by: Dietmar Eggemann <dietmar.eggemann@arm.com> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Acked-by: Sudeep Holla <sudeep.holla@arm.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent a20b705 commit 6699e91

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

arch/arm/include/asm/topology.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,13 @@
77
#include <linux/cpumask.h>
88
#include <linux/arch_topology.h>
99

10+
/* big.LITTLE switcher is incompatible with frequency invariance */
11+
#ifndef CONFIG_BL_SWITCHER
1012
/* Replace task scheduler's default frequency-invariant accounting */
1113
#define arch_set_freq_scale topology_set_freq_scale
1214
#define arch_scale_freq_capacity topology_get_freq_scale
1315
#define arch_scale_freq_invariant topology_scale_freq_invariant
16+
#endif
1417

1518
/* Replace task scheduler's default cpu-invariant accounting */
1619
#define arch_scale_cpu_capacity topology_get_cpu_scale

0 commit comments

Comments
 (0)