drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind()

fenghusthu · jernejsk · commit 6654b57866b9 · 2020-11-17T18:23:00.000+01:00
Fix to return a negative error code from the error handling case instead of 0 in function sun8i_dw_hdmi_bind(). Fixes: b7c7436 ("drm/sun4i: Implement A83T HDMI driver") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> Link: https://patchwork.freedesktop.org/patch/msgid/1605488969-5211-1-git-send-email-wangxiongfeng2@huawei.com
diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
@@ -208,6 +208,7 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct device *master,
 	phy_node = of_parse_phandle(dev->of_node, "phys", 0);
 	if (!phy_node) {
 		dev_err(dev, "Can't found PHY phandle\n");
+		ret = -EINVAL;
 		goto err_disable_clk_tmds;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -208,6 +208,7 @@ static int sun8i_dw_hdmi_bind(struct device dev, struct device master,`
`208`	`208`	`phy_node = of_parse_phandle(dev->of_node, "phys", 0);`
`209`	`209`	`if (!phy_node) {`
`210`	`210`	`dev_err(dev, "Can't found PHY phandle\n");`
	`211`	`+ ret = -EINVAL;`
`211`	`212`	`goto err_disable_clk_tmds;`
`212`	`213`	`}`
`213`	`214`