Skip to content

Commit 5cbd768

Browse files
vsyrjalarodrigovivi
authored andcommitted
drm/i915: Restore ILK-M RPS support
Restore RPS for ILK-M. We lost it when an extra HAS_RPS() check appeared in intel_rps_enable(). Unfortunaltey this just makes the performance worse on my ILK because intel_ips insists on limiting the GPU freq to the minimum. If we don't do the RPS init then intel_ips will not limit the frequency for whatever reason. Either it can't get at some required information and thus makes wrong decisions, or we mess up some weights/etc. and cause it to make the wrong decisions when RPS init has been done, or the entire thing is just wrong. Would require a bunch of reverse engineering to figure out what's going on. Cc: stable@vger.kernel.org Cc: Chris Wilson <chris@chris-wilson.co.uk> Fixes: 9c87855 ("drm/i915/gt: Use the RPM config register to determine clk frequencies") Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20201021131443.25616-1-ville.syrjala@linux.intel.com Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> (cherry picked from commit 2bf0637) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent 09a729b commit 5cbd768

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/gpu/drm/i915/i915_pci.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,7 @@ static const struct intel_device_info ilk_m_info = {
389389
GEN5_FEATURES,
390390
PLATFORM(INTEL_IRONLAKE),
391391
.is_mobile = 1,
392+
.has_rps = true,
392393
.display.has_fbc = 1,
393394
};
394395

0 commit comments

Comments
 (0)