Skip to content

Commit 59d5396

Browse files
Colin Ian KingPeter Zijlstra
authored andcommitted
x86/events/amd/iommu: Fix sizeof mismatch
An incorrect sizeof is being used, struct attribute ** is not correct, it should be struct attribute *. Note that since ** is the same size as * this is not causing any issues. Improve this fix by using sizeof(*attrs) as this allows us to not even reference the type of the pointer. Addresses-Coverity: ("Sizeof not portable (SIZEOF_MISMATCH)") Fixes: 5168654 ("x86/events/amd/iommu: Fix sysfs perf attribute groups") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lkml.kernel.org/r/20201001113900.58889-1-colin.king@canonical.com
1 parent 80a5ce1 commit 59d5396

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/x86/events/amd/iommu.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@ static __init int _init_events_attrs(void)
379379
while (amd_iommu_v2_event_descs[i].attr.attr.name)
380380
i++;
381381

382-
attrs = kcalloc(i + 1, sizeof(struct attribute **), GFP_KERNEL);
382+
attrs = kcalloc(i + 1, sizeof(*attrs), GFP_KERNEL);
383383
if (!attrs)
384384
return -ENOMEM;
385385

0 commit comments

Comments
 (0)