Skip to content

Commit 5227726

Browse files
committed
mtd: rawnand: au1550: Do not force a particular software ECC engine
Originally, commit d7157ff ("mtd: rawnand: Use the ECC framework user input parsing bits") kind of broke the logic around the initialization of several ECC engines. Unfortunately, the fix (which indeed moved the ECC initialization to the right place) did not take into account the fact that a different ECC algorithm could have been used thanks to a DT property, considering the "Hamming" algorithm entry a configuration while it was only a default. Add the necessary logic to be sure Hamming keeps being only a default. Fixes: dbffc8c ("mtd: rawnand: au1550: Move the ECC initialization to ->attach_chip()") Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20201203190340.15522-3-miquel.raynal@bootlin.com
1 parent 249a959 commit 5227726

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/mtd/nand/raw/au1550nd.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,9 @@ static int au1550nd_exec_op(struct nand_chip *this,
239239
static int au1550nd_attach_chip(struct nand_chip *chip)
240240
{
241241
chip->ecc.engine_type = NAND_ECC_ENGINE_TYPE_SOFT;
242-
chip->ecc.algo = NAND_ECC_ALGO_HAMMING;
242+
243+
if (chip->ecc.algo == NAND_ECC_ALGO_UNKNOWN)
244+
chip->ecc.algo = NAND_ECC_ALGO_HAMMING;
243245

244246
return 0;
245247
}

0 commit comments

Comments
 (0)