Skip to content

Commit 5105660

Browse files
committed
clk: tegra: Always program PLL_E when enabled
Commit bff1cef ("clk: tegra: Don't enable already enabled PLLs") added checks to avoid enabling PLLs that have already been enabled by the bootloader. However, the PLL_E configuration inherited from the bootloader isn't necessarily the one that is needed for the kernel. This can cause SATA to fail like this: [ 5.310270] phy phy-sata.6: phy poweron failed --> -110 [ 5.315604] tegra-ahci 70027000.sata: failed to power on AHCI controller: -110 [ 5.323022] tegra-ahci: probe of 70027000.sata failed with error -110 Fix this by always programming the PLL_E. This ensures that any mis- configuration by the bootloader will be overwritten by the kernel. Fixes: bff1cef ("clk: tegra: Don't enable already enabled PLLs") Reported-by: LABBE Corentin <clabbe@baylibre.com> Tested-by: Corentin Labbe <clabbe@baylibre.com> Reviewed-by: Dmitry Osipenko <digetx@gmail.com> Signed-off-by: Thierry Reding <treding@nvidia.com>
1 parent 6402e78 commit 5105660

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

drivers/clk/tegra/clk-pll.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1611,9 +1611,6 @@ static int clk_plle_tegra114_enable(struct clk_hw *hw)
16111611
unsigned long flags = 0;
16121612
unsigned long input_rate;
16131613

1614-
if (clk_pll_is_enabled(hw))
1615-
return 0;
1616-
16171614
input_rate = clk_hw_get_rate(clk_hw_get_parent(hw));
16181615

16191616
if (_get_table_rate(hw, &sel, pll->params->fixed_rate, input_rate))

0 commit comments

Comments
 (0)