Skip to content

Commit 4ec2b69

Browse files
fenghusthuzhenyw
authored andcommitted
drm/i915/gvt: return error when failing to take the module reference
When we fail to take the module reference, we go to the 'undo*' branch and return. But the returned variable 'ret' has been set as zero by the above code. Change 'ret' to '-ENODEV' in this situation. Fixes: 9bdb073 ("drm/i915/gvt: Change KVMGT as self load module") Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com> Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/1605187352-51761-1-git-send-email-wangxiongfeng2@huawei.com
1 parent edb8d77 commit 4ec2b69

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/gpu/drm/i915/gvt/kvmgt.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -829,8 +829,10 @@ static int intel_vgpu_open(struct mdev_device *mdev)
829829
/* Take a module reference as mdev core doesn't take
830830
* a reference for vendor driver.
831831
*/
832-
if (!try_module_get(THIS_MODULE))
832+
if (!try_module_get(THIS_MODULE)) {
833+
ret = -ENODEV;
833834
goto undo_group;
835+
}
834836

835837
ret = kvmgt_guest_init(mdev);
836838
if (ret)

0 commit comments

Comments
 (0)