Skip to content

Commit 4d213e7

Browse files
Zhenzhong Duanwilldeacon
authored andcommitted
iommu/vt-d: Avoid panic if iommu init fails in tboot system
"intel_iommu=off" command line is used to disable iommu but iommu is force enabled in a tboot system for security reason. However for better performance on high speed network device, a new option "intel_iommu=tboot_noforce" is introduced to disable the force on. By default kernel should panic if iommu init fail in tboot for security reason, but it's unnecessory if we use "intel_iommu=tboot_noforce,off". Fix the code setting force_on and move intel_iommu_tboot_noforce from tboot code to intel iommu code. Fixes: 7304e8f ("iommu/vt-d: Correctly disable Intel IOMMU force on") Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com> Tested-by: Lukasz Hawrylko <lukasz.hawrylko@linux.intel.com> Acked-by: Lu Baolu <baolu.lu@linux.intel.com> Link: https://lore.kernel.org/r/20201110071908.3133-1-zhenzhong.duan@gmail.com Signed-off-by: Will Deacon <will@kernel.org>
1 parent f8394f2 commit 4d213e7

3 files changed

Lines changed: 3 additions & 6 deletions

File tree

arch/x86/kernel/tboot.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -514,9 +514,6 @@ int tboot_force_iommu(void)
514514
if (!tboot_enabled())
515515
return 0;
516516

517-
if (intel_iommu_tboot_noforce)
518-
return 1;
519-
520517
if (no_iommu || swiotlb || dmar_disabled)
521518
pr_warn("Forcing Intel-IOMMU to enabled\n");
522519

drivers/iommu/intel/iommu.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ static int rwbf_quirk;
179179
* (used when kernel is launched w/ TXT)
180180
*/
181181
static int force_on = 0;
182-
int intel_iommu_tboot_noforce;
182+
static int intel_iommu_tboot_noforce;
183183
static int no_platform_optin;
184184

185185
#define ROOT_ENTRY_NR (VTD_PAGE_SIZE/sizeof(struct root_entry))
@@ -4885,7 +4885,8 @@ int __init intel_iommu_init(void)
48854885
* Intel IOMMU is required for a TXT/tboot launch or platform
48864886
* opt in, so enforce that.
48874887
*/
4888-
force_on = tboot_force_iommu() || platform_optin_force_iommu();
4888+
force_on = (!intel_iommu_tboot_noforce && tboot_force_iommu()) ||
4889+
platform_optin_force_iommu();
48894890

48904891
if (iommu_init_mempool()) {
48914892
if (force_on)

include/linux/intel-iommu.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -798,7 +798,6 @@ extern int iommu_calculate_agaw(struct intel_iommu *iommu);
798798
extern int iommu_calculate_max_sagaw(struct intel_iommu *iommu);
799799
extern int dmar_disabled;
800800
extern int intel_iommu_enabled;
801-
extern int intel_iommu_tboot_noforce;
802801
extern int intel_iommu_gfx_mapped;
803802
#else
804803
static inline int iommu_calculate_agaw(struct intel_iommu *iommu)

0 commit comments

Comments
 (0)