Skip to content

Commit 4690832

Browse files
committed
efi: efibc: check for efivars write capability
Branden reports that commit f88814c ("efi/efivars: Expose RT service availability via efivars abstraction") regresses UEFI platforms that implement GetVariable but not SetVariable when booting kernels that have EFIBC (bootloader control) enabled. The reason is that EFIBC is a user of the efivars abstraction, which was updated to permit users that rely only on the read capability, but not on the write capability. EFIBC is in the latter category, so it has to check explicitly whether efivars supports writes. Fixes: f88814c ("efi/efivars: Expose RT service availability via efivars abstraction") Tested-by: Branden Sherrell <sherrellbc@gmail.com> Link: https://lore.kernel.org/linux-efi/AE217103-C96F-4AFC-8417-83EC11962004@gmail.com/ Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
1 parent fb1201a commit 4690832

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/firmware/efi/efibc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ static int __init efibc_init(void)
8484
{
8585
int ret;
8686

87-
if (!efi_enabled(EFI_RUNTIME_SERVICES))
87+
if (!efivars_kobject() || !efivar_supports_writes())
8888
return -ENODEV;
8989

9090
ret = register_reboot_notifier(&efibc_reboot_notifier);

0 commit comments

Comments
 (0)