Skip to content

Commit 40b9905

Browse files
committed
Merge tag 'drm-intel-next-fixes-2020-10-15' of git://anongit.freedesktop.org/drm/drm-intel into drm-next
- Set all unused color plane offsets to ~0xfff again (Ville) - Fix TGL DKL PHY DP vswing handling (Ville) Signed-off-by: Dave Airlie <airlied@redhat.com> From: Rodrigo Vivi <rodrigo.vivi@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20201015181453.GA2905280@intel.com
2 parents c46a40f + 214bba5 commit 40b9905

2 files changed

Lines changed: 6 additions & 13 deletions

File tree

drivers/gpu/drm/i915/display/intel_ddi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2742,7 +2742,7 @@ tgl_dkl_phy_ddi_vswing_sequence(struct intel_encoder *encoder, int link_clock,
27422742
u32 n_entries, val, ln, dpcnt_mask, dpcnt_val;
27432743
int rate = 0;
27442744

2745-
if (type == INTEL_OUTPUT_HDMI) {
2745+
if (type != INTEL_OUTPUT_HDMI) {
27462746
struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
27472747

27482748
rate = intel_dp->link_rate;

drivers/gpu/drm/i915/display/intel_display.c

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4093,8 +4093,7 @@ static int skl_check_ccs_aux_surface(struct intel_plane_state *plane_state)
40934093
int skl_check_plane_surface(struct intel_plane_state *plane_state)
40944094
{
40954095
const struct drm_framebuffer *fb = plane_state->hw.fb;
4096-
int ret;
4097-
bool needs_aux = false;
4096+
int ret, i;
40984097

40994098
ret = intel_plane_compute_gtt(plane_state);
41004099
if (ret)
@@ -4108,28 +4107,22 @@ int skl_check_plane_surface(struct intel_plane_state *plane_state)
41084107
* it.
41094108
*/
41104109
if (is_ccs_modifier(fb->modifier)) {
4111-
needs_aux = true;
41124110
ret = skl_check_ccs_aux_surface(plane_state);
41134111
if (ret)
41144112
return ret;
41154113
}
41164114

41174115
if (intel_format_info_is_yuv_semiplanar(fb->format,
41184116
fb->modifier)) {
4119-
needs_aux = true;
41204117
ret = skl_check_nv12_aux_surface(plane_state);
41214118
if (ret)
41224119
return ret;
41234120
}
41244121

4125-
if (!needs_aux) {
4126-
int i;
4127-
4128-
for (i = 1; i < fb->format->num_planes; i++) {
4129-
plane_state->color_plane[i].offset = ~0xfff;
4130-
plane_state->color_plane[i].x = 0;
4131-
plane_state->color_plane[i].y = 0;
4132-
}
4122+
for (i = fb->format->num_planes; i < ARRAY_SIZE(plane_state->color_plane); i++) {
4123+
plane_state->color_plane[i].offset = ~0xfff;
4124+
plane_state->color_plane[i].x = 0;
4125+
plane_state->color_plane[i].y = 0;
41334126
}
41344127

41354128
ret = skl_check_main_surface(plane_state);

0 commit comments

Comments
 (0)