Skip to content

Commit 3f48b6e

Browse files
Srinivas-Kandagatlabroonie
authored andcommitted
ASoC: qcom: sdm845: set driver name correctly
With the current state of code, we would endup with something like below in /proc/asound/cards for 2 machines based on this driver. Machine 1: 0 [DB845c ]: DB845c - DB845c DB845c Machine 2: 0 [LenovoYOGAC6301]: Lenovo-YOGA-C63 - Lenovo-YOGA-C630-13Q50 LENOVO-81JL-LenovoYOGAC630_13Q50-LNVNB161216 This is not very UCM friendly both w.r.t to common up configs and card identification, and UCM2 became totally not usefull with just one ucm sdm845.conf for two machines which have different setups w.r.t HDMI and other dais. Reasons for such thing is partly because Qualcomm machine drivers never cared to set driver_name. This patch sets up driver name for the this driver to sort out the UCM integration issues! after this patch contents of /proc/asound/cards: Machine 1: 0 [DB845c ]: sdm845 - DB845c DB845c Machine 2: 0 [LenovoYOGAC6301]: sdm845 - Lenovo-YOGA-C630-13Q50 LENOVO-81JL-LenovoYOGAC630_13Q50-LNVNB161216 with this its possible to align with what UCM2 expects and we can have sdm845/DB845.conf sdm845/LENOVO-81JL-LenovoYOGAC630_13Q50-LNVNB161216.conf ... for board variants. This should scale much better! Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Link: https://lore.kernel.org/r/20201023095849.22894-1-srinivas.kandagatla@linaro.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent f47d074 commit 3f48b6e

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

sound/soc/qcom/sdm845.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
#include "qdsp6/q6afe.h"
1818
#include "../codecs/rt5663.h"
1919

20+
#define DRIVER_NAME "sdm845"
2021
#define DEFAULT_SAMPLE_RATE_48K 48000
2122
#define DEFAULT_MCLK_RATE 24576000
2223
#define TDM_BCLK_RATE 6144000
@@ -552,6 +553,7 @@ static int sdm845_snd_platform_probe(struct platform_device *pdev)
552553
if (!data)
553554
return -ENOMEM;
554555

556+
card->driver_name = DRIVER_NAME;
555557
card->dapm_widgets = sdm845_snd_widgets;
556558
card->num_dapm_widgets = ARRAY_SIZE(sdm845_snd_widgets);
557559
card->dev = dev;

0 commit comments

Comments
 (0)