Skip to content

Commit 392da33

Browse files
krzkGeorgi Djakov
authored andcommitted
interconnect: core: Simplify with dev_err_probe()
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Link: https://lore.kernel.org/r/20200902172433.1138-1-krzk@kernel.org Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
1 parent 628fdbc commit 392da33

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

drivers/interconnect/core.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -478,18 +478,14 @@ struct icc_path *of_icc_get_by_index(struct device *dev, int idx)
478478
src_data = of_icc_get_from_provider(&src_args);
479479

480480
if (IS_ERR(src_data)) {
481-
if (PTR_ERR(src_data) != -EPROBE_DEFER)
482-
dev_err(dev, "error finding src node: %ld\n",
483-
PTR_ERR(src_data));
481+
dev_err_probe(dev, PTR_ERR(src_data), "error finding src node\n");
484482
return ERR_CAST(src_data);
485483
}
486484

487485
dst_data = of_icc_get_from_provider(&dst_args);
488486

489487
if (IS_ERR(dst_data)) {
490-
if (PTR_ERR(dst_data) != -EPROBE_DEFER)
491-
dev_err(dev, "error finding dst node: %ld\n",
492-
PTR_ERR(dst_data));
488+
dev_err_probe(dev, PTR_ERR(dst_data), "error finding dst node\n");
493489
kfree(src_data);
494490
return ERR_CAST(dst_data);
495491
}

0 commit comments

Comments
 (0)