amdkfd: Check kvmalloc return before memcpy

kentrussell · alexdeucher · commit 2e3a57f4905b · 2020-11-03T21:00:40.000-05:00
If we can't kvmalloc the pcrat_image, then we shouldn't memcpy

Signed-off-by: Kent Russell &lt;kent.russell@amd.com&gt;
Reported-by: kernel test robot &lt;lkp@intel.com&gt;
Reviewed-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
Signed-off-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
@@ -798,10 +798,10 @@ int kfd_create_crat_image_acpi(void **crat_image, size_t *size)
 	}
 
 	pcrat_image = kvmalloc(crat_table->length, GFP_KERNEL);
-	memcpy(pcrat_image, crat_table, crat_table->length);
 	if (!pcrat_image)
 		return -ENOMEM;
 
+	memcpy(pcrat_image, crat_table, crat_table->length);
 	*crat_image = pcrat_image;
 	*size = crat_table->length;
 

Original file line number	Diff line number	Diff line change
`@@ -798,10 +798,10 @@ int kfd_create_crat_image_acpi(void *crat_image, size_t size)`
`798`	`798`	`}`
`799`	`799`
`800`	`800`	`pcrat_image = kvmalloc(crat_table->length, GFP_KERNEL);`
`801`		`- memcpy(pcrat_image, crat_table, crat_table->length);`
`802`	`801`	`if (!pcrat_image)`
`803`	`802`	`return -ENOMEM;`
`804`	`803`
	`804`	`+ memcpy(pcrat_image, crat_table, crat_table->length);`
`805`	`805`	`*crat_image = pcrat_image;`
`806`	`806`	`*size = crat_table->length;`
`807`	`807`