Skip to content

Commit 25c1ca6

Browse files
pizhenweiChristoph Hellwig
authored andcommitted
nvme-rdma: handle unexpected nvme completion data length
Receiving a zero length message leads to the following warnings because the CQE is processed twice: refcount_t: underflow; use-after-free. WARNING: CPU: 0 PID: 0 at lib/refcount.c:28 RIP: 0010:refcount_warn_saturate+0xd9/0xe0 Call Trace: <IRQ> nvme_rdma_recv_done+0xf3/0x280 [nvme_rdma] __ib_process_cq+0x76/0x150 [ib_core] ... Sanity check the received data length, to avoids this. Thanks to Chao Leng & Sagi for suggestions. Signed-off-by: zhenwei pi <pizhenwei@bytedance.com> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> Signed-off-by: Christoph Hellwig <hch@lst.de>
1 parent 8685699 commit 25c1ca6

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

drivers/nvme/host/rdma.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1768,6 +1768,14 @@ static void nvme_rdma_recv_done(struct ib_cq *cq, struct ib_wc *wc)
17681768
return;
17691769
}
17701770

1771+
/* sanity checking for received data length */
1772+
if (unlikely(wc->byte_len < len)) {
1773+
dev_err(queue->ctrl->ctrl.device,
1774+
"Unexpected nvme completion length(%d)\n", wc->byte_len);
1775+
nvme_rdma_error_recovery(queue->ctrl);
1776+
return;
1777+
}
1778+
17711779
ib_dma_sync_single_for_cpu(ibdev, qe->dma, len, DMA_FROM_DEVICE);
17721780
/*
17731781
* AEN requests are special as they don't time out and can

0 commit comments

Comments
 (0)