net: ethernet: ti: am65-cpsw-nuss: fix ale parameters init

grygoriyS · davem330 · commit 2074f9eaa587 · 2020-06-13T15:35:08.000-07:00
The ALE parameters structure is created on stack, so it has to be reset before passing to cpsw_ale_create() to avoid garbage values. Fixes: 93a7653 ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver") Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -1981,7 +1981,7 @@ MODULE_DEVICE_TABLE(of, am65_cpsw_nuss_of_mtable);
 
 static int am65_cpsw_nuss_probe(struct platform_device *pdev)
 {
-	struct cpsw_ale_params ale_params;
+	struct cpsw_ale_params ale_params = { 0 };
 	const struct of_device_id *of_id;
 	struct device *dev = &pdev->dev;
 	struct am65_cpsw_common *common;

Original file line number	Diff line number	Diff line change
`@@ -1981,7 +1981,7 @@ MODULE_DEVICE_TABLE(of, am65_cpsw_nuss_of_mtable);`
`1981`	`1981`
`1982`	`1982`	`static int am65_cpsw_nuss_probe(struct platform_device *pdev)`
`1983`	`1983`	`{`
`1984`		`- struct cpsw_ale_params ale_params;`
	`1984`	`+ struct cpsw_ale_params ale_params = { 0 };`
`1985`	`1985`	`const struct of_device_id *of_id;`
`1986`	`1986`	`struct device *dev = &pdev->dev;`
`1987`	`1987`	`struct am65_cpsw_common *common;`