Skip to content

Commit 1caa752

Browse files
krzkmiquelraynal
authored andcommitted
mtd: rawnand: atmel: Simplify with dev_err_probe()
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20200901142535.12819-2-krzk@kernel.org
1 parent 28acb2c commit 1caa752

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

drivers/mtd/nand/raw/atmel/nand-controller.c

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2027,13 +2027,9 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc,
20272027
platform_set_drvdata(pdev, nc);
20282028

20292029
nc->pmecc = devm_atmel_pmecc_get(dev);
2030-
if (IS_ERR(nc->pmecc)) {
2031-
ret = PTR_ERR(nc->pmecc);
2032-
if (ret != -EPROBE_DEFER)
2033-
dev_err(dev, "Could not get PMECC object (err = %d)\n",
2034-
ret);
2035-
return ret;
2036-
}
2030+
if (IS_ERR(nc->pmecc))
2031+
return dev_err_probe(dev, PTR_ERR(nc->pmecc),
2032+
"Could not get PMECC object\n");
20372033

20382034
if (nc->caps->has_dma && !atmel_nand_avoid_dma) {
20392035
dma_cap_mask_t mask;

0 commit comments

Comments
 (0)