Skip to content

Commit 1849a38

Browse files
crojewsk-intelbroonie
authored andcommitted
ASoC: Intel: atom: Remove duplicate kconfigs
SND_SST_IPC and its _PCI and _ACPI variants all target sound/soc/intel/atom solution alone. SND_SST_IPC is the core component, required for PCI and ACPI based atom platforms both. _PCI and _ACPI target Merrifield/Edison and Baytrial/Cherrytrail platforms respectively. On top of that, there is an equivalent set of configs targeting the same solution: - SND_SST_ATOM_HIFI2_PLATFORM (core) - SND_SST_ATOM_HIFI2_PLATFORM_PCI - SND_SST_ATOM_HIFI2_PLATFORM_ACPI As both sets do the same job - allow for granular platform selection - remove the duplicate set and rely on SND_SST_ATOM_HIFI2_PLATOFRM_XXX configs alone. Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com> Acked-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20201012095005.29859-1-cezary.rojewski@intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 9fe9efd commit 1849a38

3 files changed

Lines changed: 4 additions & 22 deletions

File tree

sound/soc/intel/Kconfig

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,6 @@ config SND_SOC_INTEL_SST_TOPLEVEL
1515

1616
if SND_SOC_INTEL_SST_TOPLEVEL
1717

18-
config SND_SST_IPC
19-
tristate
20-
# This option controls the IPC core for HiFi2 platforms
21-
22-
config SND_SST_IPC_PCI
23-
tristate
24-
select SND_SST_IPC
25-
# This option controls the PCI-based IPC for HiFi2 platforms
26-
# (Medfield, Merrifield).
27-
28-
config SND_SST_IPC_ACPI
29-
tristate
30-
select SND_SST_IPC
31-
# This option controls the ACPI-based IPC for HiFi2 platforms
32-
# (Baytrail, Cherrytrail)
33-
3418
config SND_SOC_INTEL_SST
3519
tristate
3620

@@ -57,7 +41,6 @@ config SND_SST_ATOM_HIFI2_PLATFORM
5741
config SND_SST_ATOM_HIFI2_PLATFORM_PCI
5842
tristate "PCI HiFi2 (Merrifield) Platforms"
5943
depends on X86 && PCI
60-
select SND_SST_IPC_PCI
6144
select SND_SST_ATOM_HIFI2_PLATFORM
6245
help
6346
If you have a Intel Merrifield/Edison platform, then
@@ -70,7 +53,6 @@ config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
7053
tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
7154
default ACPI
7255
depends on X86 && ACPI && PCI
73-
select SND_SST_IPC_ACPI
7456
select SND_SST_ATOM_HIFI2_PLATFORM
7557
select SND_SOC_ACPI_INTEL_MATCH
7658
select IOSF_MBI

sound/soc/intel/atom/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ snd-soc-sst-atom-hifi2-platform-objs := sst-mfld-platform-pcm.o \
66
obj-$(CONFIG_SND_SST_ATOM_HIFI2_PLATFORM) += snd-soc-sst-atom-hifi2-platform.o
77

88
# DSP driver
9-
obj-$(CONFIG_SND_SST_IPC) += sst/
9+
obj-$(CONFIG_SND_SST_ATOM_HIFI2_PLATFORM) += sst/

sound/soc/intel/atom/sst/Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@ snd-intel-sst-core-objs := sst.o sst_ipc.o sst_stream.o sst_drv_interface.o sst_
33
snd-intel-sst-pci-objs += sst_pci.o
44
snd-intel-sst-acpi-objs += sst_acpi.o
55

6-
obj-$(CONFIG_SND_SST_IPC) += snd-intel-sst-core.o
7-
obj-$(CONFIG_SND_SST_IPC_PCI) += snd-intel-sst-pci.o
8-
obj-$(CONFIG_SND_SST_IPC_ACPI) += snd-intel-sst-acpi.o
6+
obj-$(CONFIG_SND_SST_ATOM_HIFI2_PLATFORM) += snd-intel-sst-core.o
7+
obj-$(CONFIG_SND_SST_ATOM_HIFI2_PLATFORM_PCI) += snd-intel-sst-pci.o
8+
obj-$(CONFIG_SND_SST_ATOM_HIFI2_PLATFORM_ACPI) += snd-intel-sst-acpi.o

0 commit comments

Comments
 (0)