Skip to content

Commit 15207a9

Browse files
Fabojic23
authored andcommitted
iio: adc: mediatek: fix unset field
dev_comp field is used in a couple of places but it is never set. This results in kernel oops when dereferencing a NULL pointer. Set the `dev_comp` field correctly in the probe function. Fixes: 6d97024 ("iio: adc: mediatek: mt6577-auxadc, add mt6765 support") Signed-off-by: Fabien Parent <fparent@baylibre.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> Cc: <Stable@vger.kernel.org> Link: https://lore.kernel.org/r/20201018194644.3366846-1-fparent@baylibre.com Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
1 parent 56e4f2d commit 15207a9

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

drivers/iio/adc/mt6577_auxadc.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
#include <linux/err.h>
1010
#include <linux/kernel.h>
1111
#include <linux/module.h>
12-
#include <linux/of.h>
13-
#include <linux/of_device.h>
12+
#include <linux/mod_devicetable.h>
1413
#include <linux/platform_device.h>
14+
#include <linux/property.h>
1515
#include <linux/iopoll.h>
1616
#include <linux/io.h>
1717
#include <linux/iio/iio.h>
@@ -276,6 +276,8 @@ static int mt6577_auxadc_probe(struct platform_device *pdev)
276276
goto err_disable_clk;
277277
}
278278

279+
adc_dev->dev_comp = device_get_match_data(&pdev->dev);
280+
279281
mutex_init(&adc_dev->lock);
280282

281283
mt6577_auxadc_mod_reg(adc_dev->reg_base + MT6577_AUXADC_MISC,

0 commit comments

Comments
 (0)