Skip to content

Commit 121b8fc

Browse files
Zhihao Chengrichardweinberger
authored andcommitted
ubifs: setflags: Don't show error message when vfs_ioc_setflags_prepare() fails
Following process will trigger ubifs_err: 1. useradd -m freg (Under root) 2. cd /home/freg && mkdir mp (Under freg) 3. mount -t ubifs /dev/ubi0_0 /home/freg/mp (Under root) 4. cd /home/freg && echo 123 > mp/a (Under root) 5. cd mp && chown freg a && chgrp freg a && chmod 777 a (Under root) 6. chattr +i a (Under freg) UBIFS error (ubi0:0 pid 1723): ubifs_ioctl [ubifs]: can't modify inode 65 attributes chattr: Operation not permitted while setting flags on a This is not an UBIFS problem, it was caused by task priviliage checking on file operations. Remove error message printing from kernel just like other filesystems (eg. ext4), since we already have enough information from userspace tools. Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com> Signed-off-by: Richard Weinberger <richard@nod.at>
1 parent dd7db14 commit 121b8fc

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

fs/ubifs/ioctl.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,6 @@ static int setflags(struct inode *inode, int flags)
134134
return err;
135135

136136
out_unlock:
137-
ubifs_err(c, "can't modify inode %lu attributes", inode->i_ino);
138137
mutex_unlock(&ui->ui_mutex);
139138
ubifs_release_budget(c, &req);
140139
return err;

0 commit comments

Comments
 (0)