Skip to content

Commit 0fd1594

Browse files
committed
ARM: dts: Configure omap4 and 5 l4_abe for genpd and drop platform data
We can power off l4_abe domain when not in use when we configure it for genpd. And with that change, we can now also drop the old unused legacy platform data. Note that we also need to now use "simple-pm-bus" instead of "simple-bus" for PM runtime to get enabled for the bus. Signed-off-by: Tony Lindgren <tony@atomide.com> Acked-by: Santosh Shilimkar <ssantosh@kernel.org> Signed-off-by: Tony Lindgren <tony@atomide.com>
1 parent 587c437 commit 0fd1594

6 files changed

Lines changed: 20 additions & 68 deletions

File tree

arch/arm/boot/dts/omap4-l4-abe.dtsi

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
&l4_abe { /* 0x40100000 */
2-
compatible = "ti,omap4-l4-abe", "simple-bus";
2+
compatible = "ti,omap4-l4-abe", "simple-pm-bus";
33
reg = <0x40100000 0x400>,
44
<0x40100400 0x400>;
55
reg-names = "la", "ap";
6+
power-domains = <&prm_abe>;
7+
/* OMAP4_L4_ABE_CLKCTRL is read-only */
68
#address-cells = <1>;
79
#size-cells = <1>;
810
ranges = <0x00000000 0x40100000 0x100000>, /* segment 0 */
911
<0x49000000 0x49000000 0x100000>;
1012
segment@0 { /* 0x40100000 */
11-
compatible = "simple-bus";
13+
compatible = "simple-pm-bus";
1214
#address-cells = <1>;
1315
#size-cells = <1>;
1416
ranges =

arch/arm/boot/dts/omap4.dtsi

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -658,6 +658,12 @@
658658
#reset-cells = <1>;
659659
};
660660

661+
prm_abe: prm@500 {
662+
compatible = "ti,omap4-prm-inst", "ti,omap-prm-inst";
663+
reg = <0x500 0x100>;
664+
#power-domain-cells = <0>;
665+
};
666+
661667
prm_core: prm@700 {
662668
compatible = "ti,omap4-prm-inst", "ti,omap-prm-inst";
663669
reg = <0x700 0x100>;

arch/arm/boot/dts/omap5-l4-abe.dtsi

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
&l4_abe { /* 0x40100000 */
2-
compatible = "ti,omap5-l4-abe", "simple-bus";
2+
compatible = "ti,omap5-l4-abe", "simple-pm-bus";
33
reg = <0x40100000 0x400>,
44
<0x40100400 0x400>;
55
reg-names = "la", "ap";
6+
power-domains = <&prm_abe>;
7+
/* OMAP5_L4_ABE_CLKCTRL is read-only */
68
#address-cells = <1>;
79
#size-cells = <1>;
810
ranges = <0x00000000 0x40100000 0x100000>, /* segment 0 */
911
<0x49000000 0x49000000 0x100000>;
1012
segment@0 { /* 0x40100000 */
11-
compatible = "simple-bus";
13+
compatible = "simple-pm-bus";
1214
#address-cells = <1>;
1315
#size-cells = <1>;
1416
ranges =

arch/arm/boot/dts/omap5.dtsi

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -674,6 +674,12 @@
674674
#reset-cells = <1>;
675675
};
676676

677+
prm_abe: prm@500 {
678+
compatible = "ti,omap5-prm-inst", "ti,omap-prm-inst";
679+
reg = <0x500 0x100>;
680+
#power-domain-cells = <0>;
681+
};
682+
677683
prm_core: prm@700 {
678684
compatible = "ti,omap5-prm-inst", "ti,omap-prm-inst";
679685
reg = <0x700 0x100>;

arch/arm/mach-omap2/omap_hwmod_44xx_data.c

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -124,21 +124,6 @@ static struct omap_hwmod_class omap44xx_l4_hwmod_class = {
124124
.name = "l4",
125125
};
126126

127-
/* l4_abe */
128-
static struct omap_hwmod omap44xx_l4_abe_hwmod = {
129-
.name = "l4_abe",
130-
.class = &omap44xx_l4_hwmod_class,
131-
.clkdm_name = "abe_clkdm",
132-
.prcm = {
133-
.omap4 = {
134-
.clkctrl_offs = OMAP4_CM1_ABE_L4ABE_CLKCTRL_OFFSET,
135-
.context_offs = OMAP4_RM_ABE_AESS_CONTEXT_OFFSET,
136-
.lostcontext_mask = OMAP4430_LOSTMEM_AESSMEM_MASK,
137-
.flags = HWMOD_OMAP4_NO_CONTEXT_LOSS_BIT,
138-
},
139-
},
140-
};
141-
142127
/* l4_cfg */
143128
static struct omap_hwmod omap44xx_l4_cfg_hwmod = {
144129
.name = "l4_cfg",
@@ -771,22 +756,6 @@ static struct omap_hwmod_ocp_if omap44xx_l4_cfg__l3_main_3 = {
771756
.user = OCP_USER_MPU | OCP_USER_SDMA,
772757
};
773758

774-
/* l3_main_1 -> l4_abe */
775-
static struct omap_hwmod_ocp_if omap44xx_l3_main_1__l4_abe = {
776-
.master = &omap44xx_l3_main_1_hwmod,
777-
.slave = &omap44xx_l4_abe_hwmod,
778-
.clk = "l3_div_ck",
779-
.user = OCP_USER_MPU | OCP_USER_SDMA,
780-
};
781-
782-
/* mpu -> l4_abe */
783-
static struct omap_hwmod_ocp_if omap44xx_mpu__l4_abe = {
784-
.master = &omap44xx_mpu_hwmod,
785-
.slave = &omap44xx_l4_abe_hwmod,
786-
.clk = "ocp_abe_iclk",
787-
.user = OCP_USER_MPU | OCP_USER_SDMA,
788-
};
789-
790759
/* l3_main_1 -> l4_cfg */
791760
static struct omap_hwmod_ocp_if omap44xx_l3_main_1__l4_cfg = {
792761
.master = &omap44xx_l3_main_1_hwmod,
@@ -988,8 +957,6 @@ static struct omap_hwmod_ocp_if *omap44xx_hwmod_ocp_ifs[] __initdata = {
988957
&omap44xx_l3_main_1__l3_main_3,
989958
&omap44xx_l3_main_2__l3_main_3,
990959
&omap44xx_l4_cfg__l3_main_3,
991-
&omap44xx_l3_main_1__l4_abe,
992-
&omap44xx_mpu__l4_abe,
993960
&omap44xx_l3_main_1__l4_cfg,
994961
&omap44xx_l3_main_2__l4_per,
995962
&omap44xx_l4_cfg__l4_wkup,

arch/arm/mach-omap2/omap_hwmod_54xx_data.c

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -121,19 +121,6 @@ static struct omap_hwmod_class omap54xx_l4_hwmod_class = {
121121
.name = "l4",
122122
};
123123

124-
/* l4_abe */
125-
static struct omap_hwmod omap54xx_l4_abe_hwmod = {
126-
.name = "l4_abe",
127-
.class = &omap54xx_l4_hwmod_class,
128-
.clkdm_name = "abe_clkdm",
129-
.prcm = {
130-
.omap4 = {
131-
.clkctrl_offs = OMAP54XX_CM_ABE_L4_ABE_CLKCTRL_OFFSET,
132-
.flags = HWMOD_OMAP4_NO_CONTEXT_LOSS_BIT,
133-
},
134-
},
135-
};
136-
137124
/* l4_cfg */
138125
static struct omap_hwmod omap54xx_l4_cfg_hwmod = {
139126
.name = "l4_cfg",
@@ -395,22 +382,6 @@ static struct omap_hwmod_ocp_if omap54xx_l4_cfg__l3_main_3 = {
395382
.user = OCP_USER_MPU | OCP_USER_SDMA,
396383
};
397384

398-
/* l3_main_1 -> l4_abe */
399-
static struct omap_hwmod_ocp_if omap54xx_l3_main_1__l4_abe = {
400-
.master = &omap54xx_l3_main_1_hwmod,
401-
.slave = &omap54xx_l4_abe_hwmod,
402-
.clk = "abe_iclk",
403-
.user = OCP_USER_MPU | OCP_USER_SDMA,
404-
};
405-
406-
/* mpu -> l4_abe */
407-
static struct omap_hwmod_ocp_if omap54xx_mpu__l4_abe = {
408-
.master = &omap54xx_mpu_hwmod,
409-
.slave = &omap54xx_l4_abe_hwmod,
410-
.clk = "abe_iclk",
411-
.user = OCP_USER_MPU | OCP_USER_SDMA,
412-
};
413-
414385
/* l3_main_1 -> l4_cfg */
415386
static struct omap_hwmod_ocp_if omap54xx_l3_main_1__l4_cfg = {
416387
.master = &omap54xx_l3_main_1_hwmod,
@@ -478,8 +449,6 @@ static struct omap_hwmod_ocp_if *omap54xx_hwmod_ocp_ifs[] __initdata = {
478449
&omap54xx_l3_main_1__l3_main_3,
479450
&omap54xx_l3_main_2__l3_main_3,
480451
&omap54xx_l4_cfg__l3_main_3,
481-
&omap54xx_l3_main_1__l4_abe,
482-
&omap54xx_mpu__l4_abe,
483452
&omap54xx_l3_main_1__l4_cfg,
484453
&omap54xx_l3_main_2__l4_per,
485454
&omap54xx_l3_main_1__l4_wkup,

0 commit comments

Comments
 (0)