Skip to content

Commit 0d519cb

Browse files
committed
debugfs: remove return value of debugfs_create_devm_seqfile()
No one checks the return value of debugfs_create_devm_seqfile(), as it's not needed, so make the return value void, so that no one tries to do so in the future. Link: https://lore.kernel.org/r/20201023131037.2500765-1-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 3650b22 commit 0d519cb

3 files changed

Lines changed: 16 additions & 19 deletions

File tree

Documentation/filesystems/debugfs.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ of its elements. Note: Once array is created its size can not be changed.
199199

200200
There is a helper function to create device related seq_file::
201201

202-
struct dentry *debugfs_create_devm_seqfile(struct device *dev,
202+
void debugfs_create_devm_seqfile(struct device *dev,
203203
const char *name,
204204
struct dentry *parent,
205205
int (*read_fn)(struct seq_file *s,

fs/debugfs/file.c

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1127,24 +1127,23 @@ static const struct file_operations debugfs_devm_entry_ops = {
11271127
* file will be created in the root of the debugfs filesystem.
11281128
* @read_fn: function pointer called to print the seq_file content.
11291129
*/
1130-
struct dentry *debugfs_create_devm_seqfile(struct device *dev, const char *name,
1131-
struct dentry *parent,
1132-
int (*read_fn)(struct seq_file *s,
1133-
void *data))
1130+
void debugfs_create_devm_seqfile(struct device *dev, const char *name,
1131+
struct dentry *parent,
1132+
int (*read_fn)(struct seq_file *s, void *data))
11341133
{
11351134
struct debugfs_devm_entry *entry;
11361135

11371136
if (IS_ERR(parent))
1138-
return ERR_PTR(-ENOENT);
1137+
return;
11391138

11401139
entry = devm_kzalloc(dev, sizeof(*entry), GFP_KERNEL);
11411140
if (!entry)
1142-
return ERR_PTR(-ENOMEM);
1141+
return;
11431142

11441143
entry->read = read_fn;
11451144
entry->dev = dev;
11461145

1147-
return debugfs_create_file(name, S_IRUGO, parent, entry,
1148-
&debugfs_devm_entry_ops);
1146+
debugfs_create_file(name, S_IRUGO, parent, entry,
1147+
&debugfs_devm_entry_ops);
11491148
}
11501149
EXPORT_SYMBOL_GPL(debugfs_create_devm_seqfile);

include/linux/debugfs.h

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,9 @@ void debugfs_create_u32_array(const char *name, umode_t mode,
144144
struct dentry *parent,
145145
struct debugfs_u32_array *array);
146146

147-
struct dentry *debugfs_create_devm_seqfile(struct device *dev, const char *name,
148-
struct dentry *parent,
149-
int (*read_fn)(struct seq_file *s,
150-
void *data));
147+
void debugfs_create_devm_seqfile(struct device *dev, const char *name,
148+
struct dentry *parent,
149+
int (*read_fn)(struct seq_file *s, void *data));
151150

152151
bool debugfs_initialized(void);
153152

@@ -327,13 +326,12 @@ static inline void debugfs_create_u32_array(const char *name, umode_t mode,
327326
{
328327
}
329328

330-
static inline struct dentry *debugfs_create_devm_seqfile(struct device *dev,
331-
const char *name,
332-
struct dentry *parent,
333-
int (*read_fn)(struct seq_file *s,
334-
void *data))
329+
static inline void debugfs_create_devm_seqfile(struct device *dev,
330+
const char *name,
331+
struct dentry *parent,
332+
int (*read_fn)(struct seq_file *s,
333+
void *data))
335334
{
336-
return ERR_PTR(-ENODEV);
337335
}
338336

339337
static inline ssize_t debugfs_read_file_bool(struct file *file,

0 commit comments

Comments
 (0)