Skip to content

Commit 063a3d6

Browse files
Dan Carpentergregkh
authored andcommitted
usb: typec: stusb160x: fix some signedness bugs
These variables are enums but in this situation GCC will treat them as unsigned so the conditions are never true. Fixes: da0cb63 ("usb: typec: add support for STUSB160x Type-C controller family") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/20201023112412.GD282278@mwanda Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 3650b22 commit 063a3d6

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

drivers/usb/typec/stusb160x.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,7 @@ static int stusb160x_get_fw_caps(struct stusb160x *chip,
545545
ret = fwnode_property_read_string(fwnode, "power-role", &cap_str);
546546
if (!ret) {
547547
chip->port_type = typec_find_port_power_role(cap_str);
548-
if (chip->port_type < 0) {
548+
if ((int)chip->port_type < 0) {
549549
ret = chip->port_type;
550550
return ret;
551551
}
@@ -567,9 +567,10 @@ static int stusb160x_get_fw_caps(struct stusb160x *chip,
567567
if (!ret) {
568568
chip->pwr_opmode = typec_find_pwr_opmode(cap_str);
569569
/* Power delivery not yet supported */
570-
if (chip->pwr_opmode < 0 ||
570+
if ((int)chip->pwr_opmode < 0 ||
571571
chip->pwr_opmode == TYPEC_PWR_MODE_PD) {
572-
ret = chip->pwr_opmode < 0 ? chip->pwr_opmode : -EINVAL;
572+
ret = (int)chip->pwr_opmode < 0 ? chip->pwr_opmode :
573+
-EINVAL;
573574
dev_err(chip->dev, "bad power operation mode: %d\n",
574575
chip->pwr_opmode);
575576
return ret;

0 commit comments

Comments
 (0)