Skip to content

Commit 03c9c8f

Browse files
amitdanielkachhapwilldeacon
authored andcommitted
arm64: kprobe: clarify the comment of steppable hint instructions
The existing comment about steppable hint instruction is not complete and only describes NOP instructions as steppable. As the function aarch64_insn_is_steppable_hint allows all white-listed instruction to be probed so the comment is updated to reflect this. Signed-off-by: Amit Daniel Kachhap <amit.kachhap@arm.com> Reviewed-by: Dave Martin <dave.martin@arm.com> Link: https://lore.kernel.org/r/20200914083656.21428-7-amit.kachhap@arm.com Signed-off-by: Will Deacon <will@kernel.org>
1 parent 6560edc commit 03c9c8f

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

arch/arm64/kernel/probes/decode-insn.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,10 @@ static bool __kprobes aarch64_insn_is_steppable(u32 insn)
4343
!= AARCH64_INSN_SPCLREG_DAIF;
4444

4545
/*
46-
* The HINT instruction is is problematic when single-stepping,
47-
* except for the NOP case.
46+
* The HINT instruction is steppable only if it is in whitelist
47+
* and the rest of other such instructions are blocked for
48+
* single stepping as they may cause exception or other
49+
* unintended behaviour.
4850
*/
4951
if (aarch64_insn_is_hint(insn))
5052
return aarch64_insn_is_steppable_hint(insn);

0 commit comments

Comments
 (0)