From e2828c4f831767f857d84661367d87ce25178292 Mon Sep 17 00:00:00 2001 From: Anton Karpov Date: Tue, 4 Aug 2026 02:50:22 +0300 Subject: [PATCH 1/2] Fix four docstring parameter names that do not match the signature - rtcons.py: TemporalConstraint documents spec, the argument is times - sia2.py: SIA2Service documents url, the argument is baseurl. The module level search() really does take url, so only the class was changed - elements.py: parse_for_object documents object, the argument is object_type - mivot_utils.py: populate_instance documents as_literal, the argument is as_literals. Same line said 'default isTrue', now 'default is True' Docstrings only. --- pyvo/dal/sia2.py | 2 +- pyvo/mivot/utils/mivot_utils.py | 2 +- pyvo/registry/rtcons.py | 2 +- pyvo/utils/xml/elements.py | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pyvo/dal/sia2.py b/pyvo/dal/sia2.py index 113e32f99..2974ba8ac 100644 --- a/pyvo/dal/sia2.py +++ b/pyvo/dal/sia2.py @@ -163,7 +163,7 @@ def __init__(self, baseurl, *, capability_description=None, session=None, check_ Parameters ---------- - url : str + baseurl : str url - URL of the SIA2service (base or query endpoint) session : object optional session to use for network requests diff --git a/pyvo/mivot/utils/mivot_utils.py b/pyvo/mivot/utils/mivot_utils.py index 17573fcaf..6da26d613 100644 --- a/pyvo/mivot/utils/mivot_utils.py +++ b/pyvo/mivot/utils/mivot_utils.py @@ -293,7 +293,7 @@ def populate_instance(property_instance, class_name, Table (from parsed VOTable) of the mapped data dmtype : string common dmtype of object attributes - as_literal : boolean, optional (default isTrue) + as_literals : boolean, optional (default is True) If True, all attribute are set with literal values (@value="...") package : str, optional (default as None) Package name possibly prefixing dmroles diff --git a/pyvo/registry/rtcons.py b/pyvo/registry/rtcons.py index 32ac97d0a..8b80bcf74 100644 --- a/pyvo/registry/rtcons.py +++ b/pyvo/registry/rtcons.py @@ -1041,7 +1041,7 @@ def __init__(self, times, *, inclusive=False): Parameters ---------- - spec : astropy.Time or a 2-tuple of astropy.Time-s + times : astropy.Time or a 2-tuple of astropy.Time-s A point in time or time interval to cover. Plain numbers are interpreted as MJD. All resources *overlapping* the interval are returned. diff --git a/pyvo/utils/xml/elements.py b/pyvo/utils/xml/elements.py index 40dfa846d..db6231722 100644 --- a/pyvo/utils/xml/elements.py +++ b/pyvo/utils/xml/elements.py @@ -27,7 +27,7 @@ def parse_for_object( ---------- source : str or readable file-like object Path or file object containing a tableset xml file. - object : object type to return (subtype `~pyvo.utils.xml.elements.Element`) + object_type : object type to return (subtype `~pyvo.utils.xml.elements.Element`) pedantic : bool, optional When `True`, raise an error when the file violates the spec, otherwise issue a warning. Warnings may be controlled using From 9a165a86a1ccb404bd14479d515a16bbfb221938 Mon Sep 17 00:00:00 2001 From: Anton Karpov Date: Tue, 4 Aug 2026 16:49:42 +0300 Subject: [PATCH 2/2] Document capability_description on SIA2Service Wording suggested by the maintainer in review. --- pyvo/dal/sia2.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pyvo/dal/sia2.py b/pyvo/dal/sia2.py index 2974ba8ac..1d09fc196 100644 --- a/pyvo/dal/sia2.py +++ b/pyvo/dal/sia2.py @@ -165,6 +165,8 @@ def __init__(self, baseurl, *, capability_description=None, session=None, check_ ---------- baseurl : str url - URL of the SIA2service (base or query endpoint) + capability_description : str + Optional description of the service. session : object optional session to use for network requests check_baseurl : bool