You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add NoResetOnClose=true to PostgreSQL connection strings missing it (#2154)
Commit 36ab8b9 removed Multiplexing=true and tightened Program.cs to
require NoResetOnClose=true, but missed adding it to connection strings
that previously relied on Multiplexing=true to pass the check.
Fixes Fortunes, Fortunes EF, and Fortune Dapper failures in the
benchmarks-ci-01 Trends Database pipeline.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
connectionString: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=18;Enlist=false;Max Auto Prepare=4
26
+
connectionString: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=18;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4
Copy file name to clipboardExpand all lines: scenarios/mono.benchmarks.yml
+8-8Lines changed: 8 additions & 8 deletions
Original file line number
Diff line number
Diff line change
@@ -166,7 +166,7 @@ scenarios:
166
166
- "/p:IsDatabase=true"
167
167
environmentVariables:
168
168
database: PostgreSQL
169
-
connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;Enlist=false;Max Auto Prepare=4
169
+
connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4
170
170
load:
171
171
job: wrk
172
172
variables:
@@ -184,7 +184,7 @@ scenarios:
184
184
- "/p:IsDatabase=true"
185
185
environmentVariables:
186
186
database: PostgreSQL
187
-
connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;Enlist=false;Max Auto Prepare=4
187
+
connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4
188
188
load:
189
189
job: wrk
190
190
variables:
@@ -202,7 +202,7 @@ scenarios:
202
202
- "/p:IsDatabase=true"
203
203
environmentVariables:
204
204
database: PostgreSQL
205
-
connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;Enlist=false;Max Auto Prepare=4
205
+
connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4
206
206
load:
207
207
job: wrk
208
208
variables:
@@ -220,7 +220,7 @@ scenarios:
220
220
- "/p:IsDatabase=true"
221
221
environmentVariables:
222
222
database: PostgreSQL
223
-
connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;Enlist=false;Max Auto Prepare=4
223
+
connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4
224
224
load:
225
225
job: wrk
226
226
variables:
@@ -418,7 +418,7 @@ scenarios:
418
418
- "/p:IsDatabase=true"
419
419
environmentVariables:
420
420
database: PostgreSQL
421
-
connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;Enlist=false;Max Auto Prepare=4
421
+
connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4
422
422
load:
423
423
job: wrk
424
424
variables:
@@ -435,7 +435,7 @@ scenarios:
435
435
- "/p:IsDatabase=true"
436
436
environmentVariables:
437
437
database: PostgreSQL
438
-
connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;Enlist=false;Max Auto Prepare=4
438
+
connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4
439
439
load:
440
440
job: wrk
441
441
variables:
@@ -452,7 +452,7 @@ scenarios:
452
452
- "/p:IsDatabase=true"
453
453
environmentVariables:
454
454
database: PostgreSQL
455
-
connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;Enlist=false;Max Auto Prepare=4
455
+
connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4
456
456
load:
457
457
job: wrk
458
458
variables:
@@ -469,7 +469,7 @@ scenarios:
469
469
- "/p:IsDatabase=true"
470
470
environmentVariables:
471
471
database: PostgreSQL
472
-
connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;Enlist=false;Max Auto Prepare=4
472
+
connectionstring: Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4
0 commit comments