Skip to content

Commit af337fd

Browse files
committed
some greptile comments
1 parent 216e6b1 commit af337fd

4 files changed

Lines changed: 24 additions & 11 deletions

File tree

src/lib/actions/analytics.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,7 @@ export enum Submit {
314314
FunctionUpdateSchedule = 'submit_function_update_schedule',
315315
FunctionUpdateConfiguration = 'submit_function_update_configuration',
316316
FunctionUpdateLogging = 'submit_function_update_logging',
317+
FunctionUpdateResourceLimits = 'submit_function_update_resource_limits',
317318
FunctionUpdateTimeout = 'submit_function_update_timeout',
318319
FunctionUpdateEvents = 'submit_function_update_events',
319320
FunctionUpdateScopes = 'submit_function_key_update_scopes',
@@ -438,6 +439,7 @@ export enum Submit {
438439
SiteUpdateEvents = 'submit_site_update_events',
439440
SiteUpdateScopes = 'submit_site_key_update_scopes',
440441
SiteUpdateBuildSettings = 'submit_site_update_build_settings',
442+
SiteUpdateResourceLimits = 'submit_site_update_resource_limits',
441443
SiteUpdateSinglePageApplication = 'submit_site_update_single_page_application',
442444
SiteConnectRepo = 'submit_site_connect_repo',
443445
SiteRedeploy = 'submit_site_redeploy',

src/routes/(console)/project-[region]-[project]/functions/function-[function]/settings/updateResourceLimits.svelte

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,15 @@
2424
let originalBuild = func.buildSpecification;
2525
let originalRuntime = func.runtimeSpecification;
2626
27+
let functionId: string | undefined = undefined;
28+
$: if (func.$id !== functionId) {
29+
functionId = func.$id;
30+
buildSpecification = func.buildSpecification;
31+
runtimeSpecification = func.runtimeSpecification;
32+
}
2733
$: {
28-
originalBuild = func.buildSpecification ?? buildSpecification;
29-
originalRuntime = func.runtimeSpecification ?? runtimeSpecification;
34+
originalBuild = func.buildSpecification;
35+
originalRuntime = func.runtimeSpecification;
3036
}
3137
3238
async function updateResourceLimits() {
@@ -62,13 +68,13 @@
6268
type: 'success',
6369
message: 'Resource limits have been updated'
6470
});
65-
trackEvent(Submit.FunctionUpdateLogging);
71+
trackEvent(Submit.FunctionUpdateResourceLimits);
6672
} catch (error) {
6773
addNotification({
6874
type: 'error',
6975
message: error.message
7076
});
71-
trackError(error, Submit.FunctionUpdateLogging);
77+
trackError(error, Submit.FunctionUpdateResourceLimits);
7278
}
7379
}
7480

src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateBuildSettings.svelte

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,8 @@
112112
site.adapter = adapter;
113113
}
114114
if (specs && specs.specifications?.length) {
115-
const fallbackSlug =
116-
specs.specifications.find((s) => s.enabled)?.slug ??
117-
specs.specifications[0].slug;
115+
const enabledSpecs = specs.specifications.filter((s) => s.enabled);
116+
const fallbackSlug = enabledSpecs[0]?.slug ?? specs.specifications[0]?.slug;
118117
if (!specs.specifications.some((s) => s.slug === site.buildSpecification)) {
119118
site.buildSpecification = fallbackSlug;
120119
}

src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateResourceLimits.svelte

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,15 @@
2323
let originalBuild = site.buildSpecification;
2424
let originalRuntime = site.runtimeSpecification;
2525
26+
let siteId: string | undefined = undefined;
27+
$: if (site.$id !== siteId) {
28+
siteId = site.$id;
29+
buildSpecification = site.buildSpecification;
30+
runtimeSpecification = site.runtimeSpecification;
31+
}
2632
$: {
27-
originalBuild = site.buildSpecification ?? buildSpecification;
28-
originalRuntime = site.runtimeSpecification ?? runtimeSpecification;
33+
originalBuild = site.buildSpecification;
34+
originalRuntime = site.runtimeSpecification;
2935
}
3036
3137
async function updateResourceLimits() {
@@ -57,13 +63,13 @@
5763
type: 'success',
5864
message: 'Resource limits have been updated'
5965
});
60-
trackEvent(Submit.FunctionUpdateLogging);
66+
trackEvent(Submit.SiteUpdateResourceLimits);
6167
} catch (error) {
6268
addNotification({
6369
type: 'error',
6470
message: error.message
6571
});
66-
trackError(error, Submit.FunctionUpdateLogging);
72+
trackError(error, Submit.SiteUpdateResourceLimits);
6773
}
6874
}
6975

0 commit comments

Comments
 (0)