Skip to content

Commit 64e5a79

Browse files
authored
Merge pull request #2591 from appwrite/disable-buttons
2 parents efb2d0e + 5d222e0 commit 64e5a79

3 files changed

Lines changed: 16 additions & 9 deletions

File tree

src/lib/components/viewSelector.svelte

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
hideColumns?: boolean;
2222
allowNoColumns?: boolean;
2323
showAnyway?: boolean;
24+
disableButton?: boolean;
2425
}
2526
2627
let {
@@ -32,7 +33,8 @@
3233
hideView = false,
3334
hideColumns = false,
3435
allowNoColumns = false,
35-
showAnyway = false
36+
showAnyway = false,
37+
disableButton = false
3638
}: Props = $props();
3739
3840
let showCountBadge = $state(false);
@@ -70,7 +72,7 @@
7072
icon={onlyIcon}
7173
onclick={toggle}
7274
variant="secondary"
73-
disabled={!$columns.length && showAnyway}
75+
disabled={(!$columns.length && showAnyway) || disableButton}
7476
class={onlyIcon && !$isSmallViewport ? 'width-fix' : undefined}
7577
badge={showCountBadge ? selectedColumnsNumber.toString() : undefined}>
7678
<Icon slot="start" icon={IconViewBoards} />

src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1773,9 +1773,10 @@
17731773
}}>
17741774
{#if !column.custom && row}
17751775
{@const rowData = row[column.id]}
1776+
{@const isActions = column.id === 'actions'}
17761777
{@const isNullOrUndefined = rowData === null || typeof rowData === 'undefined'}
17771778
<span class="u-trim suggestions-empty-fake-cell">
1778-
{#if isNullOrUndefined}
1779+
{#if isNullOrUndefined && !isActions}
17791780
<Badge variant="secondary" content="NULL" size="xs" />
17801781
{:else}
17811782
{rowData}

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/+page.svelte

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,8 @@
9999
$tableColumnSuggestions.table &&
100100
$tableColumnSuggestions.table.id === page.params.table;
101101
102+
$: disableButton = canShowSuggestionsSheet;
103+
102104
async function onSelect(file: Models.File, localFile = false) {
103105
$isCsvImportInProgress = true;
104106
@@ -146,7 +148,8 @@
146148
columns={tableColumns}
147149
hideView
148150
showAnyway
149-
isCustomTable />
151+
isCustomTable
152+
{disableButton} />
150153
</div>
151154

152155
<svelte:fragment slot="tooltip">Columns</svelte:fragment>
@@ -157,7 +160,7 @@
157160
onlyIcon
158161
query={data.query}
159162
columns={filterColumns}
160-
disabled={!(hasColumns && hasValidColumns)}
163+
disabled={!(hasColumns && hasValidColumns) || disableButton}
161164
analyticsSource="database_tables" />
162165

163166
<svelte:fragment slot="tooltip">Filters</svelte:fragment>
@@ -176,15 +179,15 @@
176179
<Button
177180
secondary
178181
event={Click.DatabaseImportCsv}
179-
disabled={!(hasColumns && hasValidColumns)}
182+
disabled={!(hasColumns && hasValidColumns) || disableButton}
180183
on:click={() => (showImportCSV = true)}>
181184
Import CSV
182185
</Button>
183186
{#if !$isSmallViewport}
184187
<Button
185188
secondary
186189
event="create_row"
187-
disabled={!(hasColumns && hasValidColumns)}
190+
disabled={!(hasColumns && hasValidColumns) || disableButton}
188191
on:click={() => ($showRowCreateSheet.show = true)}>
189192
<Icon icon={IconPlus} slot="start" size="s" />
190193
Create row
@@ -211,7 +214,8 @@
211214
secondary
212215
disabled={isRefreshing ||
213216
!data.rows.total ||
214-
!(hasColumns && hasValidColumns)}
217+
!(hasColumns && hasValidColumns) ||
218+
disableButton}
215219
class="small-button-dimensions"
216220
on:click={async () => {
217221
isRefreshing = true;
@@ -233,7 +237,7 @@
233237
<Button
234238
secondary
235239
event="create_row"
236-
disabled={!(hasColumns && hasValidColumns)}
240+
disabled={!(hasColumns && hasValidColumns) || disableButton}
237241
on:click={() => ($showRowCreateSheet.show = true)}>
238242
<Icon icon={IconPlus} slot="start" size="s" />
239243
Create row

0 commit comments

Comments
 (0)