Commit 7c3a050
committed
Rename download function's Callable argument
Rename from progress_consumer to progress_subscriber, for two reasons:
1. Consistency with Builder's subscribe_output, subscribe_error, and
subscribe_progress functions, which accept "subscriber" objects.
2. There is an existing type alias ProgressConsumer used by the
Builder#subscribe_progress reporting, but the Callable argument
of download is *not* the same type as this type alias: it's
Callable[[int, int], None], not Callable[[str, int, int], None].
See also apposed/appose-java@ac5bb381 parent 9c226be commit 7c3a050
1 file changed
+4
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
101 | | - | |
| 100 | + | |
| 101 | + | |
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| |||
0 commit comments