Commit 4849c5a
Encapsulate Windows exec logic in Platforms.command(exe)
Replace the old baseCommand() method (which always returned
["cmd.exe", "/c"] on Windows, regardless of whether that was
appropriate) with a new command(exe) method that takes the executable
into account and returns the full invocation list.
This makes the "should I wrap in a shell?" decision live in Platforms
where it belongs, ensures it can't be called without providing the
executable, and eliminates the footgun that caused the parentheses bug.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent bc86914 commit 4849c5a
2 files changed
Lines changed: 18 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
322 | 322 | | |
323 | 323 | | |
324 | 324 | | |
325 | | - | |
326 | | - | |
327 | | - | |
328 | | - | |
329 | | - | |
330 | | - | |
331 | | - | |
332 | | - | |
333 | | - | |
| 325 | + | |
334 | 326 | | |
335 | 327 | | |
336 | 328 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | | - | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
96 | 105 | | |
97 | | - | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
98 | 109 | | |
99 | | - | |
100 | | - | |
101 | | - | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
102 | 113 | | |
| 114 | + | |
103 | 115 | | |
104 | 116 | | |
105 | 117 | | |
0 commit comments