test: Use rerun instead skip for flaky tests (#1670)

### Description

- Perform 3 launch attempts for tests marked as flaky, instead of
skipping them.

Author: Mantisus

pyproject.toml

@@ -107,6 +107,7 @@ dev = [
     "pydoc-markdown<5.0.0",
     "pytest-asyncio<2.0.0",
     "pytest-cov<8.0.0",
+    "pytest-rerunfailures<17.0.0",
     "pytest-timeout<3.0.0",
     "pytest-xdist<4.0.0",
     "pytest<9.0.0",

tests/unit/_autoscaling/test_autoscaled_pool.py

@@ -3,7 +3,6 @@
 from __future__ import annotations
 
 import asyncio
-import sys
 from contextlib import suppress
 from datetime import datetime, timedelta, timezone
 from itertools import chain, repeat
@@ -145,8 +144,8 @@ async def run() -> None:
         await pool.run()
 
 
-@pytest.mark.skipif(
-    sys.platform != 'linux',
+@pytest.mark.flaky(
+    rerun=3,
     reason='Test is flaky on Windows and MacOS, see https://github.com/apify/crawlee-python/issues/1655.',
 )
 async def test_autoscales(

tests/unit/browsers/test_browser_pool.py

@@ -1,6 +1,5 @@
 from __future__ import annotations
 
-import sys
 from typing import TYPE_CHECKING
 
 import pytest
@@ -63,8 +62,8 @@ async def test_multiple_plugins_new_page_creation(server_url: URL) -> None:
         assert browser_pool.total_pages_count == 3
 
 
-@pytest.mark.skipif(
-    sys.platform != 'linux',
+@pytest.mark.flaky(
+    rerun=3,
     reason='Test is flaky on Windows and MacOS, see https://github.com/apify/crawlee-python/issues/1660.',
 )
 async def test_new_page_with_each_plugin(server_url: URL) -> None:

tests/unit/crawlers/_adaptive_playwright/test_adaptive_playwright_crawler.py

@@ -2,7 +2,6 @@
 
 import asyncio
 import logging
-import sys
 from dataclasses import dataclass
 from datetime import timedelta
 from itertools import cycle
@@ -607,8 +606,8 @@ async def request_handler(context: AdaptivePlaywrightCrawlingContext) -> None:
     mocked_h2_handler.assert_has_calls([call(expected_h2_tag)])
 
 
-@pytest.mark.skipif(
-    sys.platform != 'linux',
+@pytest.mark.flaky(
+    rerun=3,
     reason='Test is flaky on Windows and MacOS, see https://github.com/apify/crawlee-python/issues/1650.',
 )
 async def test_adaptive_context_query_selector_parsel(test_urls: list[str]) -> None:

tests/unit/crawlers/_basic/test_basic_crawler.py

@@ -1302,9 +1302,8 @@ async def handler(context: BasicCrawlingContext) -> None:
 
 
 @pytest.mark.run_alone
-@pytest.mark.skipif(
-    sys.platform != 'linux',
-    reason='Test is flaky on Windows and MacOS, see https://github.com/apify/crawlee-python/issues/1652.',
+@pytest.mark.flaky(
+    reruns=3, reason='Test is flaky on Windows and MacOS, see https://github.com/apify/crawlee-python/issues/1652.'
 )
 @pytest.mark.skipif(sys.version_info[:3] < (3, 11), reason='asyncio.timeout was introduced in Python 3.11.')
 @pytest.mark.parametrize(
@@ -1328,7 +1327,11 @@ async def test_timeout_in_handler(sleep_type: str) -> None:
     double_handler_timeout_s = handler_timeout.total_seconds() * 2
     handler_sleep = iter([double_handler_timeout_s, double_handler_timeout_s, 0])
 
-    crawler = BasicCrawler(request_handler_timeout=handler_timeout, max_request_retries=max_request_retries)
+    crawler = BasicCrawler(
+        request_handler_timeout=handler_timeout,
+        max_request_retries=max_request_retries,
+        storage_client=MemoryStorageClient(),
+    )
 
     mocked_handler_before_sleep = Mock()
     mocked_handler_after_sleep = Mock()
@@ -1355,8 +1358,8 @@ async def handler(context: BasicCrawlingContext) -> None:
     assert mocked_handler_after_sleep.call_count == 1
 
 
-@pytest.mark.skipif(
-    sys.platform != 'linux',
+@pytest.mark.flaky(
+    reruns=3,
     reason='Test is flaky on Windows and MacOS, see https://github.com/apify/crawlee-python/issues/1649.',
 )
 @pytest.mark.parametrize(
@@ -1381,6 +1384,7 @@ async def test_keep_alive(
         max_requests_per_crawl=max_requests_per_crawl,
         # If more request can run in parallel, then max_requests_per_crawl is not deterministic.
         concurrency_settings=ConcurrencySettings(desired_concurrency=1, max_concurrency=1),
+        storage_client=MemoryStorageClient(),
     )
     mocked_handler = Mock()