Fix tests

Author: vdusek

tests/unit/_utils/test_urls.py

@@ -70,22 +70,23 @@ def test_validate_http_url_rejects_non_http_scheme(invalid_url: str) -> None:
 @pytest.mark.parametrize(
     ('strategy', 'origin', 'target', 'expected'),
     [
-        # 'all' lets http(s) through across hosts, but rejects non-http(s) schemes
+        # 'all' lets every URL through — scheme filtering is the caller's responsibility
         ('all', 'https://example.com/', 'https://other.test/', True),
-        ('all', 'https://example.com/', 'gopher://internal:6379/_PING', False),
-        ('all', 'https://example.com/', 'mailto:foo@bar.com', False),
-        ('all', 'https://example.com/', 'javascript:alert(1)', False),
-        ('all', 'https://example.com/', 'ftp://example.com/', False),
+        ('all', 'https://example.com/', 'gopher://internal:6379/_PING', True),
+        ('all', 'https://example.com/', 'mailto:foo@bar.com', True),
+        ('all', 'https://example.com/', 'javascript:alert(1)', True),
+        ('all', 'https://example.com/', 'ftp://example.com/', True),
         # 'same-hostname' is exact host equality
         ('same-hostname', 'https://example.com/a', 'https://example.com/b', True),
         ('same-hostname', 'https://example.com/', 'https://www.example.com/', False),
         ('same-hostname', 'https://example.com/', 'https://other.test/', False),
         ('same-hostname', 'https://example.com/', 'mailto:foo@example.com', False),
-        # 'same-domain' allows subdomains under the same registrable domain
+        # 'same-domain' allows subdomains under the same registrable domain;
+        # scheme is ignored — caller filters non-http(s) targets separately
         ('same-domain', 'https://example.com/', 'https://www.example.com/', True),
         ('same-domain', 'https://example.com/', 'https://api.example.com/', True),
         ('same-domain', 'https://example.com/', 'https://other.test/', False),
-        ('same-domain', 'https://example.com/', 'ftp://www.example.com/', False),
+        ('same-domain', 'https://example.com/', 'ftp://www.example.com/', True),
         # 'same-origin' requires scheme + host + port match
         ('same-origin', 'https://example.com/', 'https://example.com/path', True),
         ('same-origin', 'https://example.com/', 'http://example.com/', False),