From 27760d52e19ad2bf1561a309c7a95a33d066261b Mon Sep 17 00:00:00 2001 From: jaykay12 Date: Sat, 10 Oct 2026 17:05:24 +0530 Subject: [PATCH 1/3] changes --- .../solr/handler/admin/api/GetConfigAPI.java | 35 +++++++++++++++++-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/solr/core/src/java/org/apache/solr/handler/admin/api/GetConfigAPI.java b/solr/core/src/java/org/apache/solr/handler/admin/api/GetConfigAPI.java index 4dab3ed74591..f601a7eec78e 100644 --- a/solr/core/src/java/org/apache/solr/handler/admin/api/GetConfigAPI.java +++ b/solr/core/src/java/org/apache/solr/handler/admin/api/GetConfigAPI.java @@ -54,9 +54,40 @@ public void getSingleParamSet(SolrQueryRequest req, SolrQueryResponse rsp) { configHandler.handleRequest(req, rsp); } - // This endpoint currently covers a whole list of paths by using the "component" placeholder + // GET /config/... sections still via SolrConfigHandler. + // Delete a path from this list when that section is migrated to Jersey @EndPoint( - path = {"/config/{component}"}, + path = { + // Special GET shapes + "/config/overlay", + "/config/znodeVersion", + // Documented top-level sections + "/config/query", + "/config/requestHandler", + "/config/searchComponent", + "/config/updateHandler", + "/config/queryResponseWriter", + "/config/initParams", + "/config/listener", + "/config/directoryFactory", + "/config/indexConfig", + "/config/codecFactory", + // Other top-level config tags fetchable the same way + "/config/queryParser", + "/config/valueSourceParser", + "/config/transformer", + "/config/updateProcessor", + "/config/updateRequestProcessorChain", + "/config/queryConverter", + "/config/cache", + "/config/circuitBreaker", + "/config/expressible", + "/config/schemaFactory", + "/config/restManager", + "/config/statsCache", + "/config/recoveryStrategy", + "/config/indexReaderFactory" + }, method = GET, permission = CONFIG_READ_PERM) public void getComponentConfig(SolrQueryRequest req, SolrQueryResponse rsp) { From e2445b5dba9b67345d4302d5d56eb1d33fa4ed04 Mon Sep 17 00:00:00 2001 From: jaykay12 Date: Sat, 10 Oct 2026 17:09:31 +0530 Subject: [PATCH 2/3] tidy --- .../solr/handler/admin/api/GetConfigAPI.java | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/solr/core/src/java/org/apache/solr/handler/admin/api/GetConfigAPI.java b/solr/core/src/java/org/apache/solr/handler/admin/api/GetConfigAPI.java index f601a7eec78e..3e5e561c6a0e 100644 --- a/solr/core/src/java/org/apache/solr/handler/admin/api/GetConfigAPI.java +++ b/solr/core/src/java/org/apache/solr/handler/admin/api/GetConfigAPI.java @@ -58,35 +58,35 @@ public void getSingleParamSet(SolrQueryRequest req, SolrQueryResponse rsp) { // Delete a path from this list when that section is migrated to Jersey @EndPoint( path = { - // Special GET shapes - "/config/overlay", - "/config/znodeVersion", - // Documented top-level sections - "/config/query", - "/config/requestHandler", - "/config/searchComponent", - "/config/updateHandler", - "/config/queryResponseWriter", - "/config/initParams", - "/config/listener", - "/config/directoryFactory", - "/config/indexConfig", - "/config/codecFactory", - // Other top-level config tags fetchable the same way - "/config/queryParser", - "/config/valueSourceParser", - "/config/transformer", - "/config/updateProcessor", - "/config/updateRequestProcessorChain", - "/config/queryConverter", - "/config/cache", - "/config/circuitBreaker", - "/config/expressible", - "/config/schemaFactory", - "/config/restManager", - "/config/statsCache", - "/config/recoveryStrategy", - "/config/indexReaderFactory" + // Special GET shapes + "/config/overlay", + "/config/znodeVersion", + // Documented top-level sections + "/config/query", + "/config/requestHandler", + "/config/searchComponent", + "/config/updateHandler", + "/config/queryResponseWriter", + "/config/initParams", + "/config/listener", + "/config/directoryFactory", + "/config/indexConfig", + "/config/codecFactory", + // Other top-level config tags fetchable the same way + "/config/queryParser", + "/config/valueSourceParser", + "/config/transformer", + "/config/updateProcessor", + "/config/updateRequestProcessorChain", + "/config/queryConverter", + "/config/cache", + "/config/circuitBreaker", + "/config/expressible", + "/config/schemaFactory", + "/config/restManager", + "/config/statsCache", + "/config/recoveryStrategy", + "/config/indexReaderFactory" }, method = GET, permission = CONFIG_READ_PERM) From 5b541052451840e26f135a99c93e09c5534b482d Mon Sep 17 00:00:00 2001 From: jaykay12 Date: Sat, 10 Oct 2026 17:32:24 +0530 Subject: [PATCH 3/3] changes --- .../apache/solr/handler/admin/api/GetConfigAPI.java | 11 +++++++---- .../solr/handler/admin/V2ConfigAPIMappingTest.java | 2 ++ 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/solr/core/src/java/org/apache/solr/handler/admin/api/GetConfigAPI.java b/solr/core/src/java/org/apache/solr/handler/admin/api/GetConfigAPI.java index 3e5e561c6a0e..2a2db95683e5 100644 --- a/solr/core/src/java/org/apache/solr/handler/admin/api/GetConfigAPI.java +++ b/solr/core/src/java/org/apache/solr/handler/admin/api/GetConfigAPI.java @@ -55,13 +55,13 @@ public void getSingleParamSet(SolrQueryRequest req, SolrQueryResponse rsp) { } // GET /config/... sections still via SolrConfigHandler. + // Every name SolrConfig.writeMap can emit. // Delete a path from this list when that section is migrated to Jersey @EndPoint( path = { - // Special GET shapes "/config/overlay", "/config/znodeVersion", - // Documented top-level sections + "/config/luceneMatchVersion", "/config/query", "/config/requestHandler", "/config/searchComponent", @@ -72,7 +72,8 @@ public void getSingleParamSet(SolrQueryRequest req, SolrQueryResponse rsp) { "/config/directoryFactory", "/config/indexConfig", "/config/codecFactory", - // Other top-level config tags fetchable the same way + "/config/requestDispatcher", + "/config/jmx", "/config/queryParser", "/config/valueSourceParser", "/config/transformer", @@ -86,7 +87,9 @@ public void getSingleParamSet(SolrQueryRequest req, SolrQueryResponse rsp) { "/config/restManager", "/config/statsCache", "/config/recoveryStrategy", - "/config/indexReaderFactory" + "/config/indexReaderFactory", + "/config/indexConfigdeletionPolicy", + "/config/updateHandlerupdateLog" }, method = GET, permission = CONFIG_READ_PERM) diff --git a/solr/core/src/test/org/apache/solr/handler/admin/V2ConfigAPIMappingTest.java b/solr/core/src/test/org/apache/solr/handler/admin/V2ConfigAPIMappingTest.java index 0a5aaab1f88c..0498b25dd5c1 100644 --- a/solr/core/src/test/org/apache/solr/handler/admin/V2ConfigAPIMappingTest.java +++ b/solr/core/src/test/org/apache/solr/handler/admin/V2ConfigAPIMappingTest.java @@ -55,6 +55,8 @@ public void testGetSingleComponentConfig() { assertAnnotatedApiExistsFor("GET", "/config/requestDispatcher"); assertAnnotatedApiExistsFor("GET", "/config/znodeVersion"); assertAnnotatedApiExistsFor("GET", "/config/luceneMatchVersion"); + assertAnnotatedApiExistsFor("GET", "/config/indexConfigdeletionPolicy"); + assertAnnotatedApiExistsFor("GET", "/config/updateHandlerupdateLog"); } @Test