Skip to content

Commit d541b7b

Browse files
authored
Compatible with 3.x and 4.x RabbitMQ Client (#389)
1 parent c90d24e commit d541b7b

16 files changed

Lines changed: 26 additions & 19 deletions

File tree

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ Release Notes.
1111
* Support collecting dubbo thread pool metrics
1212
* Bump up byte-buddy to 1.12.19
1313
* Upgrade agent test tools
14+
* [Breaking Change] Compatible with 3.x and 4.x RabbitMQ Client, rename `rabbitmq-5.x-plugin` to `rabbitmq-plugin`
1415

1516
#### Documentation
1617

apm-sniffer/apm-sdk-plugin/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
<module>elasticsearch-6.x-plugin</module>
7171
<module>elasticsearch-7.x-plugin</module>
7272
<module>undertow-plugins</module>
73-
<module>rabbitmq-5.x-plugin</module>
73+
<module>rabbitmq-plugin</module>
7474
<module>dubbo-conflict-patch</module>
7575
<module>canal-1.x-plugin</module>
7676
<module>dubbo-2.7.x-plugin</module>

apm-sniffer/apm-sdk-plugin/rabbitmq-5.x-plugin/pom.xml renamed to apm-sniffer/apm-sdk-plugin/rabbitmq-plugin/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525
</parent>
2626
<modelVersion>4.0.0</modelVersion>
2727

28-
<artifactId>apm-rabbitmq-5.x-plugin</artifactId>
29-
<name>rabbitmq-5.x-plugin</name>
28+
<artifactId>apm-rabbitmq-plugin</artifactId>
29+
<name>rabbitmq-plugin</name>
3030
<packaging>jar</packaging>
3131

3232
<properties>

apm-sniffer/apm-sdk-plugin/rabbitmq-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/rabbitmq/ChannelNConstructorInterceptor.java renamed to apm-sniffer/apm-sdk-plugin/rabbitmq-plugin/src/main/java/org/apache/skywalking/apm/plugin/rabbitmq/ChannelNConstructorInterceptor.java

File renamed without changes.

apm-sniffer/apm-sdk-plugin/rabbitmq-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/rabbitmq/RabbitMQConsumerInterceptor.java renamed to apm-sniffer/apm-sdk-plugin/rabbitmq-plugin/src/main/java/org/apache/skywalking/apm/plugin/rabbitmq/RabbitMQConsumerInterceptor.java

File renamed without changes.

apm-sniffer/apm-sdk-plugin/rabbitmq-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/rabbitmq/RabbitMQProducerInterceptor.java renamed to apm-sniffer/apm-sdk-plugin/rabbitmq-plugin/src/main/java/org/apache/skywalking/apm/plugin/rabbitmq/RabbitMQProducerInterceptor.java

File renamed without changes.

apm-sniffer/apm-sdk-plugin/rabbitmq-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/rabbitmq/TracerConsumer.java renamed to apm-sniffer/apm-sdk-plugin/rabbitmq-plugin/src/main/java/org/apache/skywalking/apm/plugin/rabbitmq/TracerConsumer.java

File renamed without changes.

apm-sniffer/apm-sdk-plugin/rabbitmq-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/rabbitmq/define/ChannelNInstrumentation.java renamed to apm-sniffer/apm-sdk-plugin/rabbitmq-plugin/src/main/java/org/apache/skywalking/apm/plugin/rabbitmq/define/ChannelNInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public ConstructorInterceptPoint[] getConstructorsInterceptPoints() {
4545
new ConstructorInterceptPoint() {
4646
@Override
4747
public ElementMatcher<MethodDescription> getConstructorMatcher() {
48-
return takesArgumentWithType(3, "com.rabbitmq.client.MetricsCollector");
48+
return takesArgumentWithType(0, "com.rabbitmq.client.impl.AMQConnection");
4949
}
5050

5151
@Override

apm-sniffer/apm-sdk-plugin/rabbitmq-5.x-plugin/src/main/resources/skywalking-plugin.def renamed to apm-sniffer/apm-sdk-plugin/rabbitmq-plugin/src/main/resources/skywalking-plugin.def

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17-
rabbitmq-5.x=org.apache.skywalking.apm.plugin.rabbitmq.define.ChannelNInstrumentation
17+
rabbitmq=org.apache.skywalking.apm.plugin.rabbitmq.define.ChannelNInstrumentation

apm-sniffer/apm-sdk-plugin/rabbitmq-5.x-plugin/src/test/java/org/apache/skywalking/apm/plugin/rabbitmq/ChannelNConstructorInterceptorTest.java renamed to apm-sniffer/apm-sdk-plugin/rabbitmq-plugin/src/test/java/org/apache/skywalking/apm/plugin/rabbitmq/ChannelNConstructorInterceptorTest.java

File renamed without changes.

0 commit comments

Comments
 (0)