Change UDF creation error code and avoid logging thread stack in warn log (#17467)

Author: JackieTien97

iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/TSStatusCode.java

@@ -230,6 +230,7 @@ public enum TSStatusCode {
   CREATE_UDF_ERROR(1204),
   DROP_UDF_ERROR(1205),
   EXECUTE_UDF_ERROR(1206),
+  UDF_ALREADY_EXISTS(1207),
 
   // Trigger
   CREATE_TRIGGER_ERROR(1300),

iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/UDFManager.java

@@ -24,6 +24,7 @@
 import org.apache.iotdb.common.rpc.thrift.TDataNodeLocation;
 import org.apache.iotdb.common.rpc.thrift.TSStatus;
 import org.apache.iotdb.commons.conf.IoTDBConstant;
+import org.apache.iotdb.commons.exception.IoTDBRuntimeException;
 import org.apache.iotdb.commons.udf.UDFInformation;
 import org.apache.iotdb.commons.udf.UDFType;
 import org.apache.iotdb.confignode.client.async.CnToDnAsyncRequestType;
@@ -137,6 +138,8 @@ public TSStatus createFunction(TCreateFunctionReq req) {
 
       LOGGER.info("Start to activate UDF [{}] in UDF_Table on Config Nodes", udfName);
       return configManager.getConsensusManager().write(new UpdateFunctionPlan(udfInformation));
+    } catch (IoTDBRuntimeException e) {
+      return new TSStatus(e.getErrorCode()).setMessage(e.getMessage());
     } catch (Exception e) {
       LOGGER.warn(e.getMessage(), e);
       return new TSStatus(TSStatusCode.EXECUTE_STATEMENT_ERROR.getStatusCode())

iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/UDFInfo.java

@@ -21,6 +21,7 @@
 
 import org.apache.iotdb.common.rpc.thrift.Model;
 import org.apache.iotdb.common.rpc.thrift.TSStatus;
+import org.apache.iotdb.commons.exception.IoTDBRuntimeException;
 import org.apache.iotdb.commons.executable.ExecutableManager;
 import org.apache.iotdb.commons.snapshot.SnapshotProcessor;
 import org.apache.iotdb.commons.udf.UDFInformation;
@@ -96,15 +97,17 @@ public void validate(Model model, String udfName, String jarName, String jarMD5)
       throws UDFManagementException {
     if (udfTable.containsUDF(model, udfName)
         && udfTable.getUDFInformation(model, udfName).isAvailable()) {
-      throw new UDFManagementException(
-          String.format("Failed to create UDF [%s], the same name UDF has been created", udfName));
+      throw new IoTDBRuntimeException(
+          String.format("Failed to create UDF [%s], the same name UDF has been created", udfName),
+          TSStatusCode.UDF_ALREADY_EXISTS.getStatusCode());
     }
 
     if (existedJarToMD5.containsKey(jarName) && !existedJarToMD5.get(jarName).equals(jarMD5)) {
-      throw new UDFManagementException(
+      throw new IoTDBRuntimeException(
           String.format(
               "Failed to create UDF [%s], the same name Jar [%s] but different MD5 [%s] has existed",
-              udfName, jarName, jarMD5));
+              udfName, jarName, jarMD5),
+          TSStatusCode.UDF_ALREADY_EXISTS.getStatusCode());
     }
   }
 

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/ConfigExecution.java

@@ -72,6 +72,10 @@ public class ConfigExecution implements IQueryExecution {
                   TSStatusCode.DATABASE_ALREADY_EXISTS.getStatusCode(),
                   TSStatusCode.DATABASE_CONFLICT.getStatusCode(),
                   TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode(),
+                  TSStatusCode.UDF_LOAD_CLASS_ERROR.getStatusCode(),
+                  TSStatusCode.DROP_UDF_ERROR.getStatusCode(),
+                  TSStatusCode.UDF_DOWNLOAD_ERROR.getStatusCode(),
+                  TSStatusCode.UDF_ALREADY_EXISTS.getStatusCode(),
                   TSStatusCode.PATH_NOT_EXIST.getStatusCode(),
                   TSStatusCode.MEASUREMENT_ALREADY_EXISTS_IN_TEMPLATE.getStatusCode(),
                   TSStatusCode.SCHEMA_QUOTA_EXCEEDED.getStatusCode(),

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/executor/ClusterConfigTaskExecutor.java

@@ -604,7 +604,7 @@ public SettableFuture<ConfigTaskResult> createFunction(
               String.format(
                   "Failed to create UDF [%s], the given function name conflicts with the built-in function name.",
                   udfName.toUpperCase()),
-              TSStatusCode.CREATE_UDF_ERROR.getStatusCode()));
+              TSStatusCode.UDF_ALREADY_EXISTS.getStatusCode()));
       return future;
     }
     try (ConfigNodeClient client =
@@ -738,11 +738,6 @@ public SettableFuture<ConfigTaskResult> createFunction(
 
       final TSStatus executionStatus = client.createFunction(tCreateFunctionReq);
       if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != executionStatus.getCode()) {
-        LOGGER.warn(
-            "Failed to create function {}({}) because {}",
-            udfName,
-            className,
-            executionStatus.getMessage());
         future.setException(new IoTDBException(executionStatus));
       } else {
         future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));