[To dev/1.3] Pipe: Cleaned multiple potential problems in pipe module (#17396) (#17417)

Caideyipi · web-flow · commit 6309e693871e · 2026-04-02T09:38:47.000+08:00
* Cleaned multiple potential problems in pipe module (#17396) * fix * fix * fix * fix * gras-shop * fix * spls * fix * pipe-dn * logger-bug * fix * fix
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/coordinator/runtime/heartbeat/PipeHeartbeat.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/coordinator/runtime/heartbeat/PipeHeartbeat.java
@@ -55,7 +55,7 @@ public PipeHeartbeat(
       // the final results and namely these dataNodes are omitted in calculation.
       remainingEventCountMap.put(
           pipeMeta.getStaticMeta(),
-          Objects.nonNull(pipeCompletedListFromAgent)
+          Objects.nonNull(pipeRemainingEventCountListFromAgent)
               ? pipeRemainingEventCountListFromAgent.get(i)
               : 0L);
       remainingTimeMap.put(
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/source/IoTDBConfigRegionSource.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/source/IoTDBConfigRegionSource.java
@@ -101,8 +101,10 @@ protected void triggerSnapshot() {
   @Override
   public synchronized EnrichedEvent supply() throws Exception {
     final EnrichedEvent event = super.supply();
-    PipeEventCommitManager.getInstance()
-        .enrichWithCommitterKeyAndCommitId(event, creationTime, regionId);
+    if (Objects.nonNull(event)) {
+      PipeEventCommitManager.getInstance()
+          .enrichWithCommitterKeyAndCommitId(event, creationTime, regionId);
+    }
     return event;
   }
 
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/runtime/PipeAgentLauncher.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/runtime/PipeAgentLauncher.java
@@ -78,7 +78,7 @@ public static synchronized void launchPipePluginAgent(
         curList.add(uninstalledOrConflictedPipePluginMetaList.get(index + offset));
         offset++;
       }
-      index += (offset + 1);
+      index += offset;
       fetchAndSavePipePluginJars(curList);
     }
 
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/task/PipeDataNodeTaskAgent.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/task/PipeDataNodeTaskAgent.java
@@ -722,7 +722,7 @@ protected void calculateMemoryUsage(
               MESSAGE_PIPE_NOT_ENOUGH_MEMORY,
               needMemory,
               freeMemorySizeInBytes,
-              freeMemorySizeInBytes,
+              reservedMemorySizeInBytes,
               PipeMemoryManager.getTotalMemorySizeInBytes());
       LOGGER.warn(message);
       throw new PipeException(message);
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/task/connection/PipeEventCollector.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/task/connection/PipeEventCollector.java
@@ -196,7 +196,7 @@ private void collectEvent(final Event event) {
       ((PipeHeartbeatEvent) event).recordConnectorQueueSize(pendingQueue);
     }
 
-    pendingQueue.directOffer(event);
+    pendingQueue.offer(event);
     collectInvocationCount.incrementAndGet();
   }
 
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/task/subtask/sink/PipeRealtimePriorityBlockingQueue.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/task/subtask/sink/PipeRealtimePriorityBlockingQueue.java
@@ -72,7 +72,7 @@ public PipeRealtimePriorityBlockingQueue() {
   }
 
   @Override
-  public boolean directOffer(final Event event) {
+  public boolean offer(final Event event) {
     checkBeforeOffer(event);
 
     if (event instanceof TsFileInsertionEvent) {
@@ -85,18 +85,13 @@ public boolean directOffer(final Event event) {
       ((EnrichedEvent) event).decreaseReferenceCount(PipeEventCollector.class.getName(), false);
       return false;
     } else {
-      return super.directOffer(event);
+      return super.offer(event);
     }
   }
 
-  @Override
-  public boolean waitedOffer(final Event event) {
-    return directOffer(event);
-  }
-
   @Override
   public boolean put(final Event event) {
-    directOffer(event);
+    offer(event);
     return true;
   }
 
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/metric/overview/PipeResourceMetrics.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/metric/overview/PipeResourceMetrics.java
@@ -137,7 +137,7 @@ public void unbindFrom(final AbstractMetricService metricService) {
     // phantom reference count
     metricService.remove(MetricType.AUTO_GAUGE, Metric.PIPE_PHANTOM_REFERENCE_COUNT.toString());
 
-    metricService.remove(MetricType.RATE, Metric.PIPE_TSFILE_SEND_DISK_IO.toString());
+    metricService.remove(MetricType.COUNTER, Metric.PIPE_TSFILE_SEND_DISK_IO.toString());
   }
 
   public void recordDiskIO(final long bytes) {
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/metric/receiver/PipeDataNodeReceiverMetrics.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/metric/receiver/PipeDataNodeReceiverMetrics.java
@@ -282,14 +282,14 @@ private void unbind(AbstractMetricService metricService) {
         Tag.NAME.toString(),
         RECEIVER,
         Tag.TYPE.toString(),
-        "handshakeDatanodeV1");
+        "handshakeDataNodeV1");
     metricService.remove(
         MetricType.TIMER,
         Metric.PIPE_DATANODE_RECEIVER.toString(),
         Tag.NAME.toString(),
         RECEIVER,
         Tag.TYPE.toString(),
-        "handshakeDatanodeV2");
+        "handshakeDataNodeV2");
     metricService.remove(
         MetricType.TIMER,
         Metric.PIPE_DATANODE_RECEIVER.toString(),
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/processor/aggregate/AggregateProcessor.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/processor/aggregate/AggregateProcessor.java
@@ -728,7 +728,7 @@ public void collectWindowOutputs(
               throw new UnsupportedOperationException(
                   String.format(
                       "The output tablet does not support column type %s",
-                      valueColumnTypes[rowIndex]));
+                      valueColumnTypes[columnIndex]));
           }
         } else {
           bitMaps[columnIndex].mark(rowIndex);
@@ -742,7 +742,7 @@ public void collectWindowOutputs(
     int filteredCount = 0;
     for (int i = 0; i < columnNameStringList.length; ++i) {
       if (!bitMaps[i].isAllMarked()) {
-        originColumnIndex2FilteredColumnIndexMapperList[i] = ++filteredCount;
+        originColumnIndex2FilteredColumnIndexMapperList[i] = filteredCount++;
       }
     }
 
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/resource/memory/PipeDynamicMemoryBlock.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/resource/memory/PipeDynamicMemoryBlock.java
@@ -44,7 +44,7 @@ public class PipeDynamicMemoryBlock {
 
   PipeDynamicMemoryBlock(
       final @NotNull PipeModelFixedMemoryBlock fixedMemoryBlock, final long memoryUsageInBytes) {
-    this.memoryUsageInBytes = Math.min(memoryUsageInBytes, 0);
+    this.memoryUsageInBytes = Math.max(memoryUsageInBytes, 0);
     this.fixedMemoryBlock = fixedMemoryBlock;
   }
 
@@ -116,7 +116,7 @@ public void updateMemoryEfficiency(
       if (Double.isNaN(historyMemoryEfficiency)
           || Double.isInfinite(historyMemoryEfficiency)
           || historyMemoryEfficiency < 0.0) {
-        currentMemoryEfficiency = 0.0;
+        historyMemoryEfficiency = 0.0;
       }
 
       this.historyMemoryEfficiency = Math.min(historyMemoryEfficiency, 1.0);
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/client/IoTDBDataNodeAsyncClientManager.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/client/IoTDBDataNodeAsyncClientManager.java
@@ -465,7 +465,7 @@ public AsyncPipeDataTransferServiceClient borrowClient() throws Exception {
 
       while (true) {
         final TEndPoint targetNodeUrl = endPointList.get((int) (Math.random() * clientSize));
-        if (isUnhealthy(targetNodeUrl) && n <= clientSize) {
+        if (isUnhealthy(targetNodeUrl) && n < clientSize) {
           n++;
           continue;
         }
@@ -486,7 +486,7 @@ public AsyncPipeDataTransferServiceClient borrowClient() throws Exception {
       long n = 0;
       while (true) {
         for (final TEndPoint targetNodeUrl : endPointList) {
-          if (isUnhealthy(targetNodeUrl) && n <= clientSize) {
+          if (isUnhealthy(targetNodeUrl) && n < clientSize) {
             n++;
             continue;
           }
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/payload/evolvable/batch/PipeTabletEventTsFileBatch.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/payload/evolvable/batch/PipeTabletEventTsFileBatch.java
@@ -288,18 +288,19 @@ private List<File> writeTabletsToTsFiles() throws IOException, WriteProcessExcep
             e.getMessage(),
             e);
 
+        final File file = fileWriter.getIOWriter().getFile();
         try {
           fileWriter.close();
         } catch (final Exception closeException) {
           LOGGER.warn(
               "Batch id = {}: Failed to close the tsfile {} after failed to write tablets into, because {}",
               currentBatchId.get(),
-              fileWriter.getIOWriter().getFile().getPath(),
+              file.getPath(),
               closeException.getMessage(),
               closeException);
         } finally {
           // Add current writing file to the list and delete the file
-          sealedFiles.add(fileWriter.getIOWriter().getFile());
+          sealedFiles.add(file);
         }
 
         for (final File sealedFile : sealedFiles) {
@@ -309,7 +310,7 @@ private List<File> writeTabletsToTsFiles() throws IOException, WriteProcessExcep
               currentBatchId.get(),
               deleteSuccess ? "Successfully" : "Failed to",
               sealedFile.getPath(),
-              fileWriter.getIOWriter().getFile().getPath(),
+              file.getPath(),
               deleteSuccess ? "" : "Maybe the tsfile needs to be deleted manually.");
         }
         sealedFiles.clear();
@@ -319,8 +320,8 @@ private List<File> writeTabletsToTsFiles() throws IOException, WriteProcessExcep
         throw e;
       }
 
-      fileWriter.close();
       final File sealedFile = fileWriter.getIOWriter().getFile();
+      fileWriter.close();
       if (LOGGER.isDebugEnabled()) {
         LOGGER.debug(
             "Batch id = {}: Seal tsfile {} successfully.",
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/protocol/airgap/IoTDBDataRegionAirGapSink.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/protocol/airgap/IoTDBDataRegionAirGapSink.java
@@ -168,7 +168,7 @@ public void transfer(final Event event) throws Exception {
       throw new PipeConnectionException(
           String.format(
               "Network error when transfer tsfile event %s, because %s.",
-              ((PipeSchemaRegionWritePlanEvent) event).coreReportMessage(), e.getMessage()),
+              ((EnrichedEvent) event).coreReportMessage(), e.getMessage()),
           e);
     }
   }
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/protocol/websocket/WebSocketConnectorServer.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/protocol/websocket/WebSocketConnectorServer.java
@@ -35,8 +35,10 @@
 
 import java.net.InetSocketAddress;
 import java.nio.ByteBuffer;
+import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Comparator;
+import java.util.List;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.PriorityBlockingQueue;
 import java.util.concurrent.atomic.AtomicBoolean;
@@ -90,14 +92,18 @@ public synchronized void unregister(WebSocketSink connector) {
       final PriorityBlockingQueue<EventWaitingForTransfer> eventTransferQueue =
           eventsWaitingForTransfer.remove(pipeName);
       while (!eventTransferQueue.isEmpty()) {
-        eventTransferQueue.forEach(
+        final List<EventWaitingForTransfer> eventWrappers;
+        synchronized (eventTransferQueue) {
+          eventWrappers = new ArrayList<>(eventTransferQueue);
+          eventTransferQueue.clear();
+        }
+        eventWrappers.forEach(
             (eventWrapper) -> {
               if (eventWrapper.event instanceof EnrichedEvent) {
                 ((EnrichedEvent) eventWrapper.event)
                     .decreaseReferenceCount(WebSocketConnectorServer.class.getName(), false);
               }
             });
-        eventTransferQueue.clear();
         synchronized (eventTransferQueue) {
           eventTransferQueue.notifyAll();
         }
@@ -270,8 +276,10 @@ private synchronized void handleError(WebSocket webSocket, long eventId) {
 
     LOGGER.warn(
         "The tablet of commitId: {} can't be parsed by client, it will be retried later.", eventId);
-    eventTransferQueue.put(
-        new EventWaitingForTransfer(eventId, eventWrapper.connector, eventWrapper.event));
+    synchronized (eventTransferQueue) {
+      eventTransferQueue.put(
+          new EventWaitingForTransfer(eventId, eventWrapper.connector, eventWrapper.event));
+    }
   }
 
   @Override
@@ -321,7 +329,9 @@ public void addEvent(Event event, WebSocketSink connector) {
       }
     }
 
-    queue.put(new EventWaitingForTransfer(eventIdGenerator.incrementAndGet(), connector, event));
+    synchronized (queue) {
+      queue.put(new EventWaitingForTransfer(eventIdGenerator.incrementAndGet(), connector, event));
+    }
   }
 
   private class TransferThread extends Thread {
@@ -347,7 +357,8 @@ public void run() {
           }
 
           try {
-            final EventWaitingForTransfer queueElement = queue.take();
+            EventWaitingForTransfer queueElement;
+            queueElement = queue.take();
             synchronized (queue) {
               queue.notifyAll();
             }
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/source/dataregion/realtime/PipeRealtimeDataRegionHybridSource.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/source/dataregion/realtime/PipeRealtimeDataRegionHybridSource.java
@@ -58,7 +58,7 @@ protected void doExtract(final PipeRealtimeEvent event) {
     } else if (eventToExtract instanceof PipeHeartbeatEvent) {
       extractHeartbeat(event);
     } else if (eventToExtract instanceof PipeSchemaRegionWritePlanEvent) {
-      extractDirectly(event);
+      pendingQueue.offer(event);
     } else {
       throw new UnsupportedOperationException(
           String.format(
@@ -116,21 +116,7 @@ private void extractTabletInsertion(final PipeRealtimeEvent event) {
         if (state == TsFileEpoch.State.USING_BOTH) {
           event.skipReportOnCommit();
         }
-        if (!pendingQueue.waitedOffer(event)) {
-          // This would not happen, but just in case.
-          // pendingQueue is unbounded, so it should never reach capacity.
-          final String errorMessage =
-              String.format(
-                  "extractTabletInsertion: pending queue of PipeRealtimeDataRegionHybridExtractor %s "
-                      + "has reached capacity, discard tablet event %s, current state %s",
-                  this, event, event.getTsFileEpoch().getState(this));
-          LOGGER.error(errorMessage);
-          PipeDataNodeAgent.runtime()
-              .report(pipeTaskMeta, new PipeRuntimeNonCriticalException(errorMessage));
-
-          // Ignore the tablet event.
-          event.decreaseReferenceCount(PipeRealtimeDataRegionHybridSource.class.getName(), false);
-        }
+        pendingQueue.offer(event);
         break;
       default:
         throw new UnsupportedOperationException(
@@ -176,21 +162,7 @@ private void extractTsFileInsertion(final PipeRealtimeEvent event) {
       case EMPTY:
       case USING_TSFILE:
       case USING_BOTH:
-        if (!pendingQueue.waitedOffer(event)) {
-          // This would not happen, but just in case.
-          // pendingQueue is unbounded, so it should never reach capacity.
-          final String errorMessage =
-              String.format(
-                  "extractTsFileInsertion: pending queue of PipeRealtimeDataRegionHybridExtractor %s "
-                      + "has reached capacity, discard TsFile event %s, current state %s",
-                  this, event, event.getTsFileEpoch().getState(this));
-          LOGGER.error(errorMessage);
-          PipeDataNodeAgent.runtime()
-              .report(pipeTaskMeta, new PipeRuntimeNonCriticalException(errorMessage));
-
-          // Ignore the tsfile event.
-          event.decreaseReferenceCount(PipeRealtimeDataRegionHybridSource.class.getName(), false);
-        }
+        pendingQueue.offer(event);
         break;
       default:
         throw new UnsupportedOperationException(
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/source/dataregion/realtime/PipeRealtimeDataRegionLogSource.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/source/dataregion/realtime/PipeRealtimeDataRegionLogSource.java
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/source/dataregion/realtime/PipeRealtimeDataRegionSource.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/source/dataregion/realtime/PipeRealtimeDataRegionSource.java
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/source/dataregion/realtime/PipeRealtimeDataRegionTsFileSource.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/source/dataregion/realtime/PipeRealtimeDataRegionTsFileSource.java
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/TsFileDeduplicationBlockingPendingQueue.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/TsFileDeduplicationBlockingPendingQueue.java
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/agent/task/connection/BlockingPendingQueue.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/agent/task/connection/BlockingPendingQueue.java
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/datastructure/pattern/PipePattern.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/datastructure/pattern/PipePattern.java
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/sink/client/IoTDBSyncClientManager.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/sink/client/IoTDBSyncClientManager.java

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ public static synchronized void launchPipePluginAgent(`
`78`	`78`	`curList.add(uninstalledOrConflictedPipePluginMetaList.get(index + offset));`
`79`	`79`	`offset++;`
`80`	`80`	`}`
`81`		`- index += (offset + 1);`
	`81`	`+ index += offset;`
`82`	`82`	`fetchAndSavePipePluginJars(curList);`
`83`	`83`	`}`
`84`	`84`
Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,7 @@ private void collectEvent(final Event event) {`
`196`	`196`	`((PipeHeartbeatEvent) event).recordConnectorQueueSize(pendingQueue);`
`197`	`197`	`}`
`198`	`198`
`199`		`- pendingQueue.directOffer(event);`
	`199`	`+ pendingQueue.offer(event);`
`200`	`200`	`collectInvocationCount.incrementAndGet();`
`201`	`201`	`}`
`202`	`202`
Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ public void unbindFrom(final AbstractMetricService metricService) {`
`137`	`137`	`// phantom reference count`
`138`	`138`	`metricService.remove(MetricType.AUTO_GAUGE, Metric.PIPE_PHANTOM_REFERENCE_COUNT.toString());`
`139`	`139`
`140`		`- metricService.remove(MetricType.RATE, Metric.PIPE_TSFILE_SEND_DISK_IO.toString());`
	`140`	`+ metricService.remove(MetricType.COUNTER, Metric.PIPE_TSFILE_SEND_DISK_IO.toString());`
`141`	`141`	`}`
`142`	`142`
`143`	`143`	`public void recordDiskIO(final long bytes) {`
Original file line number	Diff line number	Diff line change
`@@ -728,7 +728,7 @@ public void collectWindowOutputs(`
`728`	`728`	`throw new UnsupportedOperationException(`
`729`	`729`	`String.format(`
`730`	`730`	`"The output tablet does not support column type %s",`
`731`		`- valueColumnTypes[rowIndex]));`
	`731`	`+ valueColumnTypes[columnIndex]));`
`732`	`732`	`}`
`733`	`733`	`} else {`
`734`	`734`	`bitMaps[columnIndex].mark(rowIndex);`
`@@ -742,7 +742,7 @@ public void collectWindowOutputs(`
`742`	`742`	`int filteredCount = 0;`
`743`	`743`	`for (int i = 0; i < columnNameStringList.length; ++i) {`
`744`	`744`	`if (!bitMaps[i].isAllMarked()) {`
`745`		`- originColumnIndex2FilteredColumnIndexMapperList[i] = ++filteredCount;`
	`745`	`+ originColumnIndex2FilteredColumnIndexMapperList[i] = filteredCount++;`
`746`	`746`	`}`
`747`	`747`	`}`
`748`	`748`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ public class PipeDynamicMemoryBlock {`
`44`	`44`
`45`	`45`	`PipeDynamicMemoryBlock(`
`46`	`46`	`final @NotNull PipeModelFixedMemoryBlock fixedMemoryBlock, final long memoryUsageInBytes) {`
`47`		`- this.memoryUsageInBytes = Math.min(memoryUsageInBytes, 0);`
	`47`	`+ this.memoryUsageInBytes = Math.max(memoryUsageInBytes, 0);`
`48`	`48`	`this.fixedMemoryBlock = fixedMemoryBlock;`
`49`	`49`	`}`
`50`	`50`
`@@ -116,7 +116,7 @@ public void updateMemoryEfficiency(`
`116`	`116`	`if (Double.isNaN(historyMemoryEfficiency)`
`117`	`117`	`\|\| Double.isInfinite(historyMemoryEfficiency)`
`118`	`118`	`\|\| historyMemoryEfficiency < 0.0) {`
`119`		`- currentMemoryEfficiency = 0.0;`
	`119`	`+ historyMemoryEfficiency = 0.0;`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`this.historyMemoryEfficiency = Math.min(historyMemoryEfficiency, 1.0);`