Commit 62cb6c5
committed
[FLINK-39408][tests] Fix TestNameProvider broken after JUnit 5 migration
TestNameProvider is a JUnit 4 TestRule that stores the test name in a
ThreadLocal. After FLINK-39124 migrated modules to JUnit 5, the @rule
is never triggered, so PseudoRandomValueSelector.randomize() always
gets null from getCurrentTestName(), causing all boolean config
randomizations to select the same fixed value.
Fix: add TestNameProviderExtension (JUnit 5 BeforeEachCallback /
AfterEachCallback) that delegates to TestNameProvider's static methods.
TestNameProvider itself does not depend on JUnit 5 APIs, avoiding
ClassNotFoundException in non-test runtime environments (e.g. PyFlink).
Register TestNameProviderExtension globally via META-INF/services in
all modules.1 parent 795a36e commit 62cb6c5
57 files changed
Lines changed: 155 additions & 44 deletions
File tree
- flink-clients/src/test/resources/META-INF/services
- flink-connectors
- flink-connector-base/src/test/resources/META-INF/services
- flink-connector-files/src/test/resources/META-INF/services
- flink-file-sink-common/src/test/resources/META-INF/services
- flink-hadoop-compatibility/src/test/resources/META-INF/services
- flink-container/src/test/resources/META-INF/services
- flink-core/src/test/resources/META-INF/services
- flink-docs/src/test/resources/META-INF/services
- flink-examples/flink-examples-table/src/test/resources/META-INF/services
- flink-external-resources/flink-external-resource-gpu/src/test/resources/META-INF/services
- flink-formats
- flink-avro-confluent-registry/src/test/resources/META-INF/services
- flink-avro/src/test/resources/META-INF/services
- flink-compress/src/test/resources/META-INF/services
- flink-hadoop-bulk/src/test/resources/META-INF/services
- flink-json/src/test/resources/META-INF/services
- flink-orc-nohive/src/test/resources/META-INF/services
- flink-orc/src/test/resources/META-INF/services
- flink-parquet/src/test/resources/META-INF/services
- flink-sequence-file/src/test/resources/META-INF/services
- flink-kubernetes/src/test/resources/META-INF/services
- flink-metrics
- flink-metrics-core/src/test/resources/META-INF/services
- flink-metrics-datadog/src/test/resources/META-INF/services
- flink-metrics-dropwizard/src/test/resources/META-INF/services
- flink-metrics-graphite/src/test/resources/META-INF/services
- flink-metrics-influxdb/src/test/resources/META-INF/services
- flink-metrics-jmx/src/test/resources/META-INF/services
- flink-metrics-prometheus/src/test/resources/META-INF/services
- flink-metrics-slf4j/src/test/resources/META-INF/services
- flink-metrics-statsd/src/test/resources/META-INF/services
- flink-python/src/test/resources/META-INF/services
- flink-queryable-state/flink-queryable-state-runtime/src/test/resources/META-INF/services
- flink-rpc
- flink-rpc-akka-loader/src/test/resources/META-INF/services
- flink-rpc-akka/src/test/resources/META-INF/services
- flink-rpc-core/src/test/resources/META-INF/services
- flink-runtime-web/src/test/resources/META-INF/services
- flink-runtime/src/test/resources/META-INF/services
- flink-state-backends
- flink-statebackend-common/src/test/resources/META-INF/services
- flink-statebackend-heap-spillable/src/test/resources/META-INF/services
- flink-streaming-java/src/test/resources/META-INF/services
- flink-table
- flink-sql-client/src/test/resources/META-INF/services
- flink-sql-gateway/src/test/resources/META-INF/services
- flink-sql-parser/src/test/resources/META-INF/services
- flink-table-api-java-bridge/src/test/resources/META-INF/services
- flink-table-api-java/src/test/resources/META-INF/services
- flink-table-api-scala/src/test/resources/META-INF/services
- flink-table-code-splitter/src/test/resources/META-INF/services
- flink-table-common/src/test/resources/META-INF/services
- flink-table-planner/src/test/resources/META-INF/services
- flink-test-utils-parent
- flink-test-utils-junit/src
- main/java/org/apache/flink/util
- test/resources/META-INF/services
- flink-test-utils/src/test/resources/META-INF/services
- flink-tests/src/test
- java/org/apache/flink/test/checkpointing
- resources/META-INF/services
- flink-yarn-tests/src/test/resources/META-INF/services
- flink-yarn/src/test/resources/META-INF/services
- tools/ci/flink-ci-tools/src/test/resources/META-INF/services
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
0 commit comments