Skip to content

Commit fb86851

Browse files
authored
performance: Change the default value of pax_enable_debug to false (#1093)
When the default value of pax_enable_debug is true, some debug logs will be printed by default. We need to set it to false to avoid printing these logs.
1 parent c6bddb4 commit fb86851

5 files changed

Lines changed: 7 additions & 4 deletions

File tree

contrib/pax_storage/expected/filter.out

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
set pax_enable_debug to on;
12
set pax_enable_sparse_filter = on;
23
create table pax_test.null_test_t(a int, b int, c text) using pax;
34
insert into pax_test.null_test_t(a) select null from generate_series(1,2)i;

contrib/pax_storage/expected/statistics_bloom_filter.out

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
-- m/^LOG: Missing statistics for column: .*/
77
-- end_matchignore
88
set default_table_access_method = pax;
9+
set pax_enable_debug to on;
910
--
1011
-- Test with small group
1112
--

contrib/pax_storage/sql/filter.sql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
set pax_enable_debug to on;
12
set pax_enable_sparse_filter = on;
23
create table pax_test.null_test_t(a int, b int, c text) using pax;
34

contrib/pax_storage/sql/statistics_bloom_filter.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
-- m/^LOG: Missing statistics for column: .*/
77
-- end_matchignore
88
set default_table_access_method = pax;
9-
9+
set pax_enable_debug to on;
1010
--
1111
-- Test with small group
1212
--

contrib/pax_storage/src/cpp/comm/guc.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ namespace pax {
5858
#define PAX_MIN_BLOOM_FILTER_WORK_MEMORY_BYTES (1 * 1024)
5959
#define PAX_MAX_BLOOM_FILTER_WORK_MEMORY_BYTES (INT_MAX)
6060

61-
bool pax_enable_debug = true;
61+
bool pax_enable_debug = false;
6262
bool pax_enable_sparse_filter = true;
6363
bool pax_enable_row_filter = false;
6464
int pax_scan_reuse_buffer_size = 0;
@@ -127,8 +127,8 @@ static bool CheckDefaultStorageFormat(char **newval, void **extra,
127127

128128
void DefineGUCs() {
129129
DefineCustomBoolVariable("pax_enable_debug", "enable pax debug", NULL,
130-
&pax::pax_enable_debug, true, PGC_USERSET, 0, NULL,
131-
NULL, NULL);
130+
&pax::pax_enable_debug, false, PGC_USERSET,
131+
GUC_GPDB_NEED_SYNC, NULL, NULL, NULL);
132132

133133
DefineCustomBoolVariable("pax_enable_sparse_filter",
134134
"enable pax filter, contains min/max and bloom "

0 commit comments

Comments
 (0)