Fix writable CTE cause wrong matview data status.

CTE is not well supported in GPDB, if a writable operation
inside CTE is actually executed, it may cause matview data
status fail to catch up with the underlying relation.

create table t_cte_issue_582(i int, j int);
create materialized view mv_t_cte_issue_582 as select j from
t_cte_issue_582 where i = 1;
with mod1 as (insert into t_cte_issue_582 values(1, 1) returning *)
select * from mod1;

The CTE sql will insert data into t_cte_issue_582, and the data
status of matviews have that relation should be updated.

Fix CTE part issue of #582

Authored-by: Zhang Mingli avamingli@gmail.com

Author: avamingli

src/backend/executor/execMain.c

@@ -1045,39 +1045,40 @@ standard_ExecutorRun(QueryDesc *queryDesc,
 		 * after that.
 		 */
 		if (IS_QD_OR_SINGLENODE() &&
-			((es_processed > 0 || estate->es_processed > 0) ||
-			!queryDesc->plannedstmt->canSetTag))
+			(operation == CMD_INSERT || operation == CMD_UPDATE || operation == CMD_DELETE ||
+				queryDesc->plannedstmt->hasModifyingCTE) &&
+			((es_processed > 0 || estate->es_processed > 0) || !queryDesc->plannedstmt->canSetTag))
 		{
-			if (operation == CMD_INSERT ||
-				operation == CMD_UPDATE ||
-				operation == CMD_DELETE)
+			List		*rtable = queryDesc->plannedstmt->rtable;
+			int			length = list_length(rtable);
+			ListCell	*lc;
+			foreach(lc, queryDesc->plannedstmt->resultRelations)
 			{
-				List		*rtable =queryDesc->plannedstmt->rtable;
-				int			length = list_length(rtable);
-				ListCell	*lc;
-				foreach(lc, queryDesc->plannedstmt->resultRelations)
-				{
-					int varno = lfirst_int(lc);
+				int varno = lfirst_int(lc);
 
-					/* Avoid crash in case we don't find a rte. */
-					if (varno > length + 1)
-					{
-						ereport(WARNING, (errmsg("could not find rte of varno: %u ", varno)));
-						continue;
-					}
+				/* Avoid crash in case we don't find a rte. */
+				if (varno > length + 1)
+				{
+					ereport(WARNING, (errmsg("could not find rte of varno: %u ", varno)));
+					continue;
+				}
 
-					RangeTblEntry *rte = rt_fetch(varno, rtable);
-					switch (operation)
+				RangeTblEntry *rte = rt_fetch(varno, rtable);
+				switch (operation)
+				{
+					case CMD_INSERT:
+						SetRelativeMatviewAuxStatus(rte->relid, MV_DATA_STATUS_EXPIRED_INSERT_ONLY);
+						break;
+					case CMD_UPDATE:
+					case CMD_DELETE:
+						SetRelativeMatviewAuxStatus(rte->relid, MV_DATA_STATUS_EXPIRED);
+						break;
+					default:
 					{
-						case CMD_INSERT:
-							SetRelativeMatviewAuxStatus(rte->relid, MV_DATA_STATUS_EXPIRED_INSERT_ONLY);
-							break;
-						case CMD_UPDATE:
-						case CMD_DELETE:
+						/* If there were writable CTE, just mark it as expired. */
+						if (queryDesc->plannedstmt->hasModifyingCTE)
 							SetRelativeMatviewAuxStatus(rte->relid, MV_DATA_STATUS_EXPIRED);
-							break;
-						default:
-							break;
+						break;
 					}
 				}
 			}

src/test/regress/expected/matview_data.out

@@ -401,6 +401,36 @@ select mvname, datastatus from gp_matview_aux where mvname = 'mv_t2_issue_582';
  mv_t2_issue_582 | i
 (1 row)
 
+abort;
+--
+-- test issue https://github.com/cloudberrydb/cloudberrydb/issues/582
+-- test writable CTE
+--
+begin;
+create table t_cte_issue_582(i int, j int);
+NOTICE:  Table doesn't have 'DISTRIBUTED BY' clause -- Using column named 'i' as the Cloudberry Database data distribution key for this table.
+HINT:  The 'DISTRIBUTED BY' clause determines the distribution of data. Make sure column(s) chosen are the optimal data distribution key to minimize skew.
+create materialized view mv_t_cte_issue_582 as select j from t_cte_issue_582 where i = 1;
+NOTICE:  Table doesn't have 'DISTRIBUTED BY' clause -- Using column(s) named 'j' as the Cloudberry Database data distribution key for this table.
+HINT:  The 'DISTRIBUTED BY' clause determines the distribution of data. Make sure column(s) chosen are the optimal data distribution key to minimize skew.
+select mvname, datastatus from gp_matview_aux where mvname = 'mv_t_cte_issue_582';
+       mvname       | datastatus 
+--------------------+------------
+ mv_t_cte_issue_582 | u
+(1 row)
+
+with mod1 as (insert into t_cte_issue_582 values(1, 1) returning *) select * from mod1;
+ i | j 
+---+---
+ 1 | 1
+(1 row)
+
+select mvname, datastatus from gp_matview_aux where mvname = 'mv_t_cte_issue_582';
+       mvname       | datastatus 
+--------------------+------------
+ mv_t_cte_issue_582 | e
+(1 row)
+
 abort;
 drop schema matview_data_schema cascade;
 NOTICE:  drop cascades to 3 other objects

src/test/regress/sql/matview_data.sql

@@ -146,6 +146,18 @@ select count(*) from t2_issue_582;
 select mvname, datastatus from gp_matview_aux where mvname = 'mv_t2_issue_582';
 abort;
 
+--
+-- test issue https://github.com/cloudberrydb/cloudberrydb/issues/582
+-- test writable CTE
+--
+begin;
+create table t_cte_issue_582(i int, j int);
+create materialized view mv_t_cte_issue_582 as select j from t_cte_issue_582 where i = 1;
+select mvname, datastatus from gp_matview_aux where mvname = 'mv_t_cte_issue_582';
+with mod1 as (insert into t_cte_issue_582 values(1, 1) returning *) select * from mod1;
+select mvname, datastatus from gp_matview_aux where mvname = 'mv_t_cte_issue_582';
+abort;
+
 drop schema matview_data_schema cascade;
 reset enable_answer_query_using_materialized_views;
 reset optimizer;