[AQUMV] Fix materialized view rename to also update gp_matview_aux

Fix #1116

This addresses issue where renaming a materialized view wasn't
properly updating the corresponding entry in gp_matview_aux system
table.

The fix maintains data integrity between materialized views and their
auxiliary metadata by ensuring both are renamed atomically during
ALTER MATERIALIZED VIEW RENAME operations.

Authored-by: Zhang Mingli avamingli@gmail.com

Author: avamingli

src/backend/catalog/gp_matview_aux.c

@@ -601,4 +601,44 @@ addRelationMVRefCount(Oid relid, int32 mvrefcount)
 	heap_freetuple(tuple);
 
 	table_close(pgrel, RowExclusiveLock);
-}
+}
+
+/*
+ * Rename matview's name in gp_matview_aux.
+ */
+void
+mvaux_rename(Oid mvoid, char* newname)
+{
+	HeapTuple	tuple;
+	HeapTuple	newtuple;
+	Relation 	mvauxRel;
+	NameData	mvname;
+	Datum		valuesAtt[Natts_gp_matview_aux];
+	bool		nullsAtt[Natts_gp_matview_aux];
+	bool		replacesAtt[Natts_gp_matview_aux];
+
+	tuple = SearchSysCacheCopy1(MVAUXOID, ObjectIdGetDatum(mvoid));
+
+	if (!HeapTupleIsValid(tuple))
+		return;
+
+	mvauxRel = table_open(GpMatviewAuxId, RowExclusiveLock);
+
+	MemSet(valuesAtt, 0, sizeof(valuesAtt));
+	MemSet(nullsAtt, false, sizeof(nullsAtt));
+	MemSet(replacesAtt, false, sizeof(replacesAtt));
+
+	replacesAtt[Anum_gp_matview_aux_mvname -1] = true;
+
+	namestrcpy(&mvname, newname);
+	valuesAtt[Anum_gp_matview_aux_mvname - 1] = NameGetDatum(&mvname);
+
+	newtuple = heap_modify_tuple(tuple, RelationGetDescr(mvauxRel),
+									  valuesAtt, nullsAtt, replacesAtt);
+
+	CatalogTupleUpdate(mvauxRel, &newtuple->t_self, newtuple);
+	heap_freetuple(newtuple);
+	table_close(mvauxRel, RowExclusiveLock);
+
+	CommandCounterIncrement();
+}

src/backend/commands/tablecmds.c

@@ -4519,6 +4519,10 @@ RenameRelation(RenameStmt *stmt)
 	/* Do the work */
 	RenameRelationInternal(relid, stmt->newname, false, is_index_stmt);
 
+	/* Try to Rename in gp_matview_aux too. */
+	if (stmt->renameType == OBJECT_MATVIEW)
+		mvaux_rename(relid, stmt->newname);
+
 	/*
 	 * if relation is a partitioned table, rename all children tables of it.
 	 */

src/include/catalog/gp_matview_aux.h

@@ -94,4 +94,6 @@ extern bool MatviewIsGeneralyUpToDate(Oid mvoid);
 
 extern bool MatviewIsUpToDate(Oid mvoid);
 
+extern void mvaux_rename(Oid mvoid, char* newname);
+
 #endif			/* GP_MATVIEW_AUX_H */

src/test/regress/expected/matview_data.out

@@ -867,6 +867,32 @@ from gp_segment_configuration where role = 'p' and content = -1;
 --
 -- End of Maintain materialized views on partitioned tables from bottom to up.
 --
+-- Test Rename matview.
+begin;
+create materialized view mv_name1 as
+select * from par with no data;
+NOTICE:  Table doesn't have 'DISTRIBUTED BY' clause -- Using column(s) named 'a' as the Apache Cloudberry data distribution key for this table.
+HINT:  The 'DISTRIBUTED BY' clause determines the distribution of data. Make sure column(s) chosen are the optimal data distribution key to minimize skew.
+select count(*) from gp_matview_aux where mvname = 'mv_name1';
+ count 
+-------
+     1
+(1 row)
+
+alter materialized view mv_name1 rename to mv_name2;
+select count(*) from gp_matview_aux where mvname = 'mv_name1';
+ count 
+-------
+     0
+(1 row)
+
+select count(*) from gp_matview_aux where mvname = 'mv_name2';
+ count 
+-------
+     1
+(1 row)
+
+abort;
 --start_ignore
 drop schema matview_data_schema cascade;
 NOTICE:  drop cascades to 3 other objects

src/test/regress/sql/matview_data.sql

@@ -333,6 +333,16 @@ from gp_segment_configuration where role = 'p' and content = -1;
 -- End of Maintain materialized views on partitioned tables from bottom to up.
 --
 
+-- Test Rename matview.
+begin;
+create materialized view mv_name1 as
+select * from par with no data;
+select count(*) from gp_matview_aux where mvname = 'mv_name1';
+
+alter materialized view mv_name1 rename to mv_name2;
+select count(*) from gp_matview_aux where mvname = 'mv_name1';
+select count(*) from gp_matview_aux where mvname = 'mv_name2';
+abort;
 
 --start_ignore
 drop schema matview_data_schema cascade;