feat: remove unnecessary dependencies from ng_application and ng_test

Remove various dependencies

BREAKING CHANGE:

Various related dependencies (jasmine, karma) have been removed from `ng_application` and `ng_test` . These dependencies are not always required, especially when using alternative testing setups like Vite for  or when developing zoneless applications. This change reduces the default dependency footprint and provides more flexibility for users.

Projects relying on these implicitly provided dependencies will now need to declare them explicitly.

Closes #70

Author: alan-agius4

MODULE.bazel

@@ -18,7 +18,7 @@ rules_ts_ext.deps(
     ts_integrity = "sha512-CWBzXQrc/qOkhidw1OzBTQuYRbfyxDXJMVJ1XNwUHGROVmuaeiEm3OslpZ1RV96d7SKKjZKrSJu3+t/xlw3R9A==",
     ts_version = "5.9.2",
 )
-use_repo(rules_ts_ext, npm_typescript="rules_angular_npm_typescript")
+use_repo(rules_ts_ext, npm_typescript = "rules_angular_npm_typescript")
 
 node = use_extension("@rules_nodejs//nodejs:extensions.bzl", "node")
 node.toolchain(

setup/BUILD.bazel

@@ -1 +1 @@
-# Create to create a package location for being able to load at this point in the directory structure.
+# Create to create a package location for being able to load at this point in the directory structure.

setup/bzl_library.bzl

@@ -1,4 +1,5 @@
 "Workaround for https://github.com/bazelbuild/bazel-skylib/pull/571"
+
 load("@bazel_skylib//:bzl_library.bzl", _bzl_library = "bzl_library")
 load("@bazel_skylib//rules:build_test.bzl", "build_test")
 

src/architect/BUILD.bazel

@@ -12,27 +12,27 @@ bzl_library(
     name = "ng_application",
     srcs = ["ng_application.bzl"],
     deps = [
-        "@aspect_rules_js//js:defs",
         ":utils",
+        "@aspect_rules_js//js:defs",
     ],
 )
 
 bzl_library(
     name = "ng_library",
     srcs = ["ng_library.bzl"],
     deps = [
+        ":utils",
         "@aspect_rules_js//js:defs",
         "@jq.bzl//jq",
-        ":utils",
     ],
 )
 
 bzl_library(
     name = "ng_test",
     srcs = ["ng_test.bzl"],
     deps = [
-        "@aspect_rules_js//js:defs",
         ":utils",
+        "@aspect_rules_js//js:defs",
     ],
 )
 

src/architect/ng_application.bzl

@@ -13,7 +13,6 @@ NPM_DEPS = lambda node_modules: ["/".join([node_modules, s]) for s in [
     "@angular",  # Take all of them, since the list varies across angular versions
     "rxjs",
     "tslib",
-    "zone.js",
 ]]
 
 def ng_application(

src/architect/ng_library.bzl

@@ -1,7 +1,7 @@
 "Macro definition to package an angular library"
 
-load("@jq.bzl//jq:jq.bzl", "jq")
 load("@aspect_rules_js//js:defs.bzl", "js_library", "js_run_binary")
+load("@jq.bzl//jq:jq.bzl", "jq")
 load(":utils.bzl", "TEST_PATTERNS", "ng_bin")
 
 # Idiomatic configuration files created by `ng generate`
@@ -14,10 +14,12 @@ LIBRARY_CONFIG = [
 NPM_DEPS = lambda node_modules: ["/".join([node_modules, s]) for s in [
     "@angular/build",
     "@angular/common",
+    "@angular/compiler",
+    "@angular/compiler-cli",
     "@angular/core",
-    "@angular/router",
     "rxjs",
     "tslib",
+    "ng-packagr",
 ]]
 
 def ng_library(name, node_modules, ng_config, project_name = None, srcs = [], deps = [], **kwargs):

src/architect/ng_test.bzl

@@ -10,17 +10,8 @@ TEST_CONFIG = [
 
 NPM_DEPS = lambda node_modules: ["/".join([node_modules, s]) for s in [
     "@angular",  # Take all of them, since the list varies across angular versions
-    "@types/jasmine",
-    "@types/node",
-    "jasmine-core",
-    "karma",
-    "karma-chrome-launcher",
-    "karma-coverage",
-    "karma-jasmine",
-    "karma-jasmine-html-reporter",
     "tslib",
     "rxjs",
-    "zone.js",
 ]]
 
 def ng_test(name, node_modules, ng_config, args = [], project_name = None, srcs = [], deps = [], **kwargs):

src/ng_package/angular_package_format.bzl

@@ -251,7 +251,7 @@ def _angular_package_format_impl(ctx):
         ] if _ != ""])
 
         bundle_name_base = primary_bundle_name if is_primary_entry_point else entry_point
-        bundle_name_base = bundle_name_base.replace('/', '-')
+        bundle_name_base = bundle_name_base.replace("/", "-")
 
         # Store the collected entry point in a list of all entry-points. This
         # can be later passed to the packager as a manifest.

src/ng_package/index.bzl

@@ -3,12 +3,12 @@ load("//src/ng_package:angular_package_format.bzl", "angular_package_format")
 load("//src/ng_package/text_replace:index.bzl", "text_replace")
 
 def ng_package(
-    name,
-    nested_packages = [],
-    substitutions = {},
-    tags = [],
-    replace_prefixes = {},
-    **kwargs):
+        name,
+        nested_packages = [],
+        substitutions = {},
+        tags = [],
+        replace_prefixes = {},
+        **kwargs):
     angular_package_format(
         name = "%s_apf" % name,
         **kwargs

src/ng_package/packager/BUILD.bazel

@@ -1,29 +1,30 @@
 load("@aspect_rules_js//js:defs.bzl", "js_binary")
-load("@aspect_rules_ts//ts:defs.bzl", "ts_project", "ts_config")
+load("@aspect_rules_ts//ts:defs.bzl", "ts_config", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
+
 ts_config(
-  name = "tsconfig",
-  src = "tsconfig.json",
+    name = "tsconfig",
+    src = "tsconfig.json",
 )
 
 ts_project(
     name = "packager_lib",
     srcs = [
-      "api.ts",
-      "cross-entry-point-imports.ts",
-      "index.ts",
+        "api.ts",
+        "cross-entry-point-imports.ts",
+        "index.ts",
     ],
     tsconfig = ":tsconfig",
     deps = [
         "//:node_modules/@types/node",
-        "//:node_modules/typescript",
         "//:node_modules/tinyglobby",
+        "//:node_modules/typescript",
     ],
 )
 
 js_binary(
     name = "bin",
     data = [":packager_lib"],
     entry_point = ":index.js",
-)
+)