Public readonly properties instead of getters

Author: trowski

examples/3-listen.php

@@ -34,9 +34,9 @@
 foreach ($listener as $notification) {
     \printf(
         "Received notification from PID %d on channel '%s' with payload: %s\n",
-        $notification->getPid(),
-        $notification->getChannel(),
-        $notification->getPayload()
+        $notification->pid,
+        $notification->channel,
+        $notification->payload,
     );
 }
 

examples/4-multi-listen.php

@@ -5,9 +5,9 @@
 
 use Amp\Future;
 use Amp\Postgres\PostgresConfig;
+use Amp\Postgres\PostgresConnectionPool;
 use Amp\Postgres\PostgresListener;
 use Amp\Postgres\PostgresNotification;
-use Amp\Postgres\PostgresConnectionPool;
 use function Amp\async;
 use function Amp\delay;
 
@@ -56,9 +56,9 @@
     foreach ($listener as $notification) {
         \printf(
             "Received notification from PID %d on channel '%s' with payload: %s\n",
-            $notification->getPid(),
-            $notification->getChannel(),
-            $notification->getPayload()
+            $notification->pid,
+            $notification->channel,
+            $notification->payload,
         );
     }
 };

src/PostgresNotification.php

@@ -10,30 +10,9 @@ final class PostgresNotification
      * @param string $payload Message payload.
      */
     public function __construct(
-        private readonly string $channel,
-        private readonly int $pid,
-        private readonly string $payload,
+        public readonly string $channel,
+        public readonly int $pid,
+        public readonly string $payload,
     ) {
     }
-
-    /**
-     * @return non-empty-string
-     */
-    public function getChannel(): string
-    {
-        return $this->channel;
-    }
-
-    /**
-     * @return positive-int
-     */
-    public function getPid(): int
-    {
-        return $this->pid;
-    }
-
-    public function getPayload(): string
-    {
-        return $this->payload;
-    }
 }

test/AbstractConnectionTest.php

@@ -57,7 +57,7 @@ public function testListen()
 
         /** @var PostgresNotification $notification */
         foreach ($listener as $notification) {
-            $this->assertSame($notification->getPayload(), (string) $count++);
+            $this->assertSame($notification->payload, (string) $count++);
         }
 
         $this->assertSame(2, $count);
@@ -81,7 +81,7 @@ public function testNotify()
 
         /** @var PostgresNotification $notification */
         foreach ($listener as $notification) {
-            $this->assertSame($notification->getPayload(), (string) $count++);
+            $this->assertSame($notification->payload, (string) $count++);
         }
 
         $this->assertSame(2, $count);