[perf] #57 Preferred to chose index with auto_increment column when slave apply binlog

  Description
  -----------
  In row binlog format, slave chose index when apply binlog use such order:
  1) primary key
  2) unique key without null columns
  3) normal index or unique key with null columns

  Actually, in situation 3 we should chose index with auto_increment column
  first, after this patch, the new order is
  1) primary key
  2) unique key without null columns
  3) normal index with auto_increment columns
  4) normal index without auto_increment columns or unique key with null columns

Author: AliSQL

mysql-test/suite/rds/r/perf_slave_apply_use_autoinc_col_issue57.result

@@ -0,0 +1,24 @@
+include/master-slave.inc
+Warnings:
+Note	####	Sending passwords in plain text without SSL/TLS is extremely insecure.
+Note	####	Storing MySQL user name or password information in the master info repository is not secure and is therefore not recommended. Please consider using the USER and PASSWORD connection options for START SLAVE; see the 'START SLAVE Syntax' in the MySQL Manual for more information.
+[connection master]
+create table t1(c1 int auto_increment, c2 int, c3 int, key(c1,c2), key(c2)) engine=innodb;
+insert into t1 values(1,1,1);
+insert into t1 values(2,2,2);
+update t1 set c3=10;
+create table t2(c1 int, c2 int auto_increment, c3 int, key(c1), key(c2)) engine=innodb;
+insert into t2 values(1,1,1);
+insert into t2 values(2,2,2);
+update t2 set c3=10;
+select * from t1;
+c1	c2	c3
+1	1	10
+2	2	10
+select * from t2;
+c1	c2	c3
+1	1	10
+2	2	10
+drop table t1;
+drop table t2;
+include/rpl_end.inc

mysql-test/suite/rds/t/perf_slave_apply_use_autoinc_col_issue57-master.opt

@@ -0,0 +1 @@
+--binlog-format=row

mysql-test/suite/rds/t/perf_slave_apply_use_autoinc_col_issue57-slave.opt

@@ -0,0 +1 @@
+--binlog-format=row

mysql-test/suite/rds/t/perf_slave_apply_use_autoinc_col_issue57.test

@@ -0,0 +1,27 @@
+--source include/have_log_bin.inc
+--source include/master-slave.inc
+
+connection master;
+create table t1(c1 int auto_increment, c2 int, c3 int, key(c1,c2), key(c2)) engine=innodb;
+insert into t1 values(1,1,1);
+insert into t1 values(2,2,2);
+
+update t1 set c3=10;
+
+create table t2(c1 int, c2 int auto_increment, c3 int, key(c1), key(c2)) engine=innodb;
+insert into t2 values(1,1,1);
+insert into t2 values(2,2,2);
+
+update t2 set c3=10;
+
+sync_slave_with_master;
+select * from t1;
+select * from t2;
+
+connection master;
+drop table t1;
+drop table t2;
+
+sync_slave_with_master;
+
+--source include/rpl_end.inc

sql/log_event.cc

@@ -9922,6 +9922,20 @@ search_key_in_table(TABLE *table, MY_BITMAP *bi_cols, uint key_type)
   if (key_type & MULTIPLE_KEY_FLAG && table->s->keys)
   {
     DBUG_PRINT("debug", ("Searching for K."));
+
+    /* auot_increment index has higher priority over other secondary indexes */
+    if (table->found_next_number_field)
+    {
+      keyinfo= table->key_info + table->s->next_number_index;
+
+      res= are_all_columns_signaled_for_key(keyinfo, bi_cols) ?
+            table->s->next_number_index : MAX_KEY;
+
+      if (res < MAX_KEY &&
+          table->s->usable_indexes().is_set(res))
+        DBUG_RETURN(res);
+    }
+
     for (key=0,keyinfo= table->key_info ;
          (key < table->s->keys) && (res == MAX_KEY);
          key++,keyinfo++)