Fix CI: linter errors, mypy types, and add httpx to test deps

- Fix ruff import sorting in __init__.py, test_sync_client.py,
  test_async_client.py
- Fix ruff-format: async_client.py await parenthesization,
  string concatenation
- Fix mypy: add return type to __getattr__, add type:ignore for
  optional httpx import
- Add httpx to test dependencies so async tests work in CI
- Remove redundant explicit imports from base.py shim (covered by *)

https://claude.ai/code/session_01Pimg4VAco2v4srPeZj44Zm

Author: claude

pyproject.toml

@@ -30,7 +30,7 @@ Homepage = "https://github.com/ad-m/python-anticaptcha"
 
 [project.optional-dependencies]
 async = ["httpx>=0.24"]
-tests = ["pytest", "pytest-asyncio", "retry", "selenium"]
+tests = ["pytest", "pytest-asyncio", "httpx>=0.24", "retry", "selenium"]
 docs = ["sphinx", "sphinx-rtd-theme"]
 
 [tool.setuptools.package-data]

python_anticaptcha/__init__.py

@@ -1,9 +1,9 @@
 import contextlib
 from importlib.metadata import PackageNotFoundError, version
 
-from .sync_client import AnticaptchaClient, Job
 from .exceptions import AnticaptchaException
 from .proxy import Proxy
+from .sync_client import AnticaptchaClient, Job
 from .tasks import (
     AntiGateTask,
     AntiGateTaskProxyless,
@@ -29,7 +29,7 @@
     __version__ = version(__name__)
 
 
-def __getattr__(name: str):
+def __getattr__(name: str) -> type:
     if name in ("AsyncAnticaptchaClient", "AsyncJob"):
         from .async_client import AsyncAnticaptchaClient, AsyncJob
 

python_anticaptcha/async_client.py

@@ -7,7 +7,7 @@
 from urllib.parse import urljoin
 
 try:
-    import httpx
+    import httpx  # type: ignore[import-not-found]
 except ImportError:
     httpx = None  # type: ignore[assignment]
 
@@ -129,8 +129,7 @@ def __init__(
     ) -> None:
         if httpx is None:
             raise ImportError(
-                "httpx is required for async support. "
-                "Install it with: pip install python-anticaptcha[async]"
+                "httpx is required for async support. Install it with: pip install python-anticaptcha[async]"
             )
         self.client_key = client_key or os.environ.get("ANTICAPTCHA_API_KEY")
         if not self.client_key:
@@ -186,19 +185,19 @@ async def createTask(self, task: BaseTask) -> AsyncJob:
             "softId": self.SOFT_ID,
             "languagePool": self.language_pool,
         }
-        response = (await self.session.post(
-            urljoin(self.base_url, self.CREATE_TASK_URL),
-            json=request,
-            timeout=self.response_timeout,
-        )).json()
+        response = (
+            await self.session.post(
+                urljoin(self.base_url, self.CREATE_TASK_URL),
+                json=request,
+                timeout=self.response_timeout,
+            )
+        ).json()
         await self._check_response(response)
         return AsyncJob(self, response["taskId"])
 
     async def getTaskResult(self, task_id: int) -> dict[str, Any]:
         request = {"clientKey": self.client_key, "taskId": task_id}
-        response = (await self.session.post(
-            urljoin(self.base_url, self.TASK_RESULT_URL), json=request
-        )).json()
+        response = (await self.session.post(urljoin(self.base_url, self.TASK_RESULT_URL), json=request)).json()
         await self._check_response(response)
         return response
 
@@ -207,33 +206,25 @@ async def getBalance(self) -> float:
             "clientKey": self.client_key,
             "softId": self.SOFT_ID,
         }
-        response = (await self.session.post(
-            urljoin(self.base_url, self.BALANCE_URL), json=request
-        )).json()
+        response = (await self.session.post(urljoin(self.base_url, self.BALANCE_URL), json=request)).json()
         await self._check_response(response)
         return response["balance"]
 
     async def getAppStats(self, soft_id: int, mode: str) -> dict[str, Any]:
         request = {"clientKey": self.client_key, "softId": soft_id, "mode": mode}
-        response = (await self.session.post(
-            urljoin(self.base_url, self.APP_STAT_URL), json=request
-        )).json()
+        response = (await self.session.post(urljoin(self.base_url, self.APP_STAT_URL), json=request)).json()
         await self._check_response(response)
         return response
 
     async def reportIncorrectImage(self, task_id: int) -> bool:
         request = {"clientKey": self.client_key, "taskId": task_id}
-        response = (await self.session.post(
-            urljoin(self.base_url, self.REPORT_IMAGE_URL), json=request
-        )).json()
+        response = (await self.session.post(urljoin(self.base_url, self.REPORT_IMAGE_URL), json=request)).json()
         await self._check_response(response)
         return bool(response.get("status", False))
 
     async def reportIncorrectRecaptcha(self, task_id: int) -> bool:
         request = {"clientKey": self.client_key, "taskId": task_id}
-        response = (await self.session.post(
-            urljoin(self.base_url, self.REPORT_RECAPTCHA_URL), json=request
-        )).json()
+        response = (await self.session.post(urljoin(self.base_url, self.REPORT_RECAPTCHA_URL), json=request)).json()
         await self._check_response(response)
         return response["status"] == "success"
 

python_anticaptcha/base.py

@@ -1,3 +1,2 @@
 # Backward compatibility — canonical location is sync_client.py
 from .sync_client import *  # noqa: F401,F403
-from .sync_client import Job, AnticaptchaClient

tests/test_async_client.py

@@ -1,10 +1,11 @@
-from unittest.mock import patch, MagicMock, AsyncMock
+from unittest.mock import AsyncMock, MagicMock, patch
+
 import pytest
 
 from python_anticaptcha.async_client import (
+    SLEEP_EVERY_CHECK_FINISHED,
     AsyncAnticaptchaClient,
     AsyncJob,
-    SLEEP_EVERY_CHECK_FINISHED,
 )
 from python_anticaptcha.exceptions import AnticaptchaException
 
@@ -180,11 +181,13 @@ class TestAsyncJobJoinOnCheck:
     @patch("python_anticaptcha.async_client.asyncio.sleep", new_callable=AsyncMock)
     async def test_on_check_called_each_iteration(self, mock_sleep):
         client = MagicMock()
-        client.getTaskResult = AsyncMock(side_effect=[
-            {"status": "processing"},
-            {"status": "processing"},
-            {"status": "ready", "solution": {}},
-        ])
+        client.getTaskResult = AsyncMock(
+            side_effect=[
+                {"status": "processing"},
+                {"status": "processing"},
+                {"status": "ready", "solution": {}},
+            ]
+        )
         job = AsyncJob(client, task_id=1)
         callback = MagicMock()
         await job.join(on_check=callback)

tests/test_sync_client.py

@@ -2,8 +2,8 @@
 
 import pytest
 
-from python_anticaptcha.sync_client import SLEEP_EVERY_CHECK_FINISHED, AnticaptchaClient, Job
 from python_anticaptcha.exceptions import AnticaptchaException
+from python_anticaptcha.sync_client import SLEEP_EVERY_CHECK_FINISHED, AnticaptchaClient, Job
 
 
 class TestAnticaptchaClientInit: