From dbf350ff34f1a16150234e1630e1a10793b0810d Mon Sep 17 00:00:00 2001 From: Alexandre Trovato Date: Sat, 13 Feb 2021 21:19:09 +0100 Subject: [PATCH] Fix node8 github action --- .github/workflows/nodepackage.yml | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/.github/workflows/nodepackage.yml b/.github/workflows/nodepackage.yml index 2b845e06d..dfd12eb3b 100644 --- a/.github/workflows/nodepackage.yml +++ b/.github/workflows/nodepackage.yml @@ -13,16 +13,8 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - os: [ - ubuntu-latest, - macos-latest, - ] - node: [ - 8, - 10, - 12, - 13, - ] + os: [ubuntu-latest, macos-latest] + node: [8, 10, 12, 13] steps: - uses: actions/checkout@v2 - uses: actions/setup-node@v1 @@ -45,11 +37,20 @@ jobs: export CC="g++-4.8" fi npm install + + if [ ${{ matrix.node }} = 8 ]; then + # mocha 8+ is not compatible with Node 8 + npm install mocha@7.2.0 + fi + npm run test - name: Lint run: | if [ ${{ matrix.node }} = 6 ]; then # ESLint 6+ is not compatible with Node 6 exit 0 + elif [ ${{ matrix.node }} = 8 ]; then + # ESLint 7+ is not compatible with Node 8 + exit 0 fi npm run lint